Ensure reconnect loop in ChannelProvider terminates when disposed

[ramonsmits]

• Fixed ChannelProvider Publish reconnection attempts continue forever after IEndpointInstance had been stopped #1268

1. ChannelProvider now has a CancellationTokenSource that gets cancelled when it is Disposed to ensure any reconnect while loop to be stopped
2. Shutdown Handler will teardown and dispose existing channel if it exists.

[ramonsmits]

There is another reconnection loop that needs to be looked at: The one in the message pump. Has that been examined to see if it would have a similar issue?

Yes, that has been examined by @danielmarbach and that already has cancellation support that will ensure the loop will be terminated:

NServiceBus.RabbitMQ/src/NServiceBus.Transport.RabbitMQ/Receiving/MessagePump.cs

Lines 262 to 301 in aa68a7d

	async Task Reconnect(CancellationToken cancellationToken)
	{
	try
	{
	while (!cancellationToken.IsCancellationRequested)
	{
	try
	{
	if (connection.IsOpen)
	{
	connection.Close();
	}
	connection.Dispose();
	Logger.InfoFormat("'{0}': Attempting to reconnect in {1} seconds.", name, retryDelay.TotalSeconds);
	await Task.Delay(retryDelay, cancellationToken).ConfigureAwait(false);
	ConnectToBroker();
	break;
	}
	catch (Exception ex) when (!ex.IsCausedBy(cancellationToken))
	{
	Logger.InfoFormat("'{0}': Reconnecting to the broker failed: {1}", name, ex);
	}
	}
	Logger.InfoFormat("'{0}': Connection to the broker reestablished successfully.", name);
	}
	catch (Exception ex) when (ex.IsCausedBy(cancellationToken))
	{
	Logger.DebugFormat("'{0}': Reconnection canceled since the transport is being stopped: {1}", name, ex);
	}
	catch (Exception ex)
	{
	Logger.WarnFormat("'{0}': Unexpected error while reconnecting: '{1}'", name, ex);
	}
	}

Feels like there are too many changes here that are clouding up the actual fix required, which would be to abort the reconnection loop if the channel provider has been shut down.

You are absolutely right. Removed the "wait for reconnect loop" logic.

Stale

[danielmarbach]

Closed in favor of #1435