Skip to content

Fix thread-safe comparison used to optimize circuit breaker's Success method #1056

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Fix thread-safe comparison used to optimize circuit breaker's Success method #1056

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fabb5ad
Fix thread-safe comparison used to optimize circuit breaker's Success…
DavidBoike Sep 30, 2024
394a6bb
The falureCount does have to be reset to 0 at some point
DavidBoike Sep 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions src/Transport/Receiving/RepeatedFailuresOverTimeCircuitBreaker.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,9 +23,8 @@ public RepeatedFailuresOverTimeCircuitBreaker(string name, TimeSpan timeToWaitBe

public void Success()
{
var oldValue = Interlocked.Exchange(ref failureCount, 0);

if (oldValue == 0)
// If the failure count was already zero, replace it with zero (no change) and then return original
if (Interlocked.CompareExchange(ref failureCount, 0, 0) == 0)
Copy link
Contributor

@awright18 awright18 Sep 30, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems like it would solve both problems.

//if there have been no failures previously then return
if(Interlocked.Read(ref failureCount) == 0 )
{
	return;
}
else //if there were previous failures then it's ok to disarm now.
{
   if(Interlocked.Read(ref failureCount) > 0) //not sure if this check is necessary or not.
   {
	  Interlocked.Exchange(ref failureCount, 0);
   }
}

{
return;
}
Expand Down