-
Notifications
You must be signed in to change notification settings - Fork 19
enforce event to topic map if the endpoint specifies #1242
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 15 commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
b69595e
enforce event to topic map if the endpoint specifies
PhilBastian f37bd85
clean up using
PhilBastian f18f73a
update approval file
PhilBastian 1525dec
test for exception on unmapped event publish
PhilBastian 9985343
move ThrowIfUnmappedEventTypes to its own subtype of topologyoptions …
PhilBastian e57a596
clone topolgyoptions to topicpereventtopologyoptions
PhilBastian b1f05b0
Revert "clone topolgyoptions to topicpereventtopologyoptions"
PhilBastian e0f043a
Revert "move ThrowIfUnmappedEventTypes to its own subtype of topology…
PhilBastian 6b7d152
handle migrationtopologyoptions always throwing for unmapped event types
PhilBastian f8e7b7b
add clarifying comment on source of regex
PhilBastian 0682423
make analyser happy
PhilBastian de97db0
Small tweaks to the migration options
danielmarbach 9acea2a
Roundtrip setting
danielmarbach 651478d
Nit
danielmarbach 37d0f31
Cluster tests
danielmarbach 4be01be
Approve
danielmarbach File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same comment as above. I think this is the time when we need to introduce the
TopicPerEventTopologyOptions
again (we killed the type because it was empty at the time and said we could always reintroduce it later).There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Alternative name suggestions: ThrowForUnmappedEventTypes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
discussed in call: having a new subclass of
TopologyOptions
which now becomes the 'true' representation of options for TopicPerEvent topology introduces potential breaking changes and difficulty in obsoleting which aren't worth this change. Instead we are forcing this property to true forMigrationTopologyOptions
since that's the expected behaviour there