Merge pull request #901 from Particular/missing-icon

Show warning icon for successful retried messages

Author: HEskandari

src/ServiceInsight/MessageList/MessageStatusIconInfo.cs

@@ -22,7 +22,7 @@ static MessageStatusIconInfo()
                 [MessageStatus.Failed] = "Failed",
                 [MessageStatus.ArchivedFailure] = "Archived",
                 [MessageStatus.RepeatedFailure] = "RepeatedFailed",
-                [MessageStatus.ResolvedSuccessfully] = "ResolvedSuccess",
+                [MessageStatus.ResolvedSuccessfully] = "Successful",
                 [MessageStatus.RetryIssued] = "RetryIssued",
             };
         }
@@ -42,7 +42,7 @@ public MessageStatusIconInfo(StoredMessage message, Func<string, ImageSource> re
             Image = GetImage();
         }
 
-        private bool Warn(StoredMessage message)
+        private static bool Warn(StoredMessage message)
         {
             return message.ProcessingTime < TimeSpan.Zero ||
                    message.CriticalTime < TimeSpan.Zero ||
@@ -70,11 +70,11 @@ ImageSource GetImage()
             var currentStatus = statusSpecified ? Status : MessageStatus.Successful;
             var imageName = $"MessageStatus_{statusToIconNameMap[currentStatus]}";
 
-            if (HasWarn)
+            if (HasWarn || Status == MessageStatus.ResolvedSuccessfully)
             {
                 imageName += "_Warn";
             }
-            
+
             var image = resourceFinder(imageName); 
 
             return image;