Skip to content

Conversation

lailabougria
Copy link
Contributor

@lailabougria lailabougria commented Aug 22, 2024

This PR contains all changes related to assertion model according to the constraint assertion model.

Using a script, we apply all assertion rules provided by the NUnit.Analyzers package. In addition, some manual interventions are done when applicable.

Plan of action

  • ⚠️ Build the solution and resolve any remaining errors or warnings
  • ✅ Review the assertions commit by commit
  • 👀 Invite another pair of eyes to re-review
  • 🏗 Set the PR to In progress on the board

@lailabougria lailabougria self-assigned this Aug 22, 2024
@lailabougria lailabougria enabled auto-merge (squash) August 22, 2024 11:51
@danielmarbach danielmarbach force-pushed the nunit-assertions-migration branch from 9ab6b44 to 22ae080 Compare August 22, 2024 13:19
@danielmarbach danielmarbach self-requested a review August 22, 2024 13:24
@lailabougria lailabougria merged commit a10b402 into master Aug 22, 2024
27 checks passed
@lailabougria lailabougria deleted the nunit-assertions-migration branch August 22, 2024 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants