Skip to content

Conversation

bartekwasielak
Copy link
Contributor

@bartekwasielak bartekwasielak commented Oct 6, 2025

What needs to be addressed:

  • How Edit & Retry works (points)
  • Emphasize that the 'retried' message has a different ID
  • No ServiceControl events
  • failing silently (?)
  • situations when Edit & Retry is discarded (logs a warning, but doesn't communicate the reason to the ServicePulse user - to be checked if already covered)
    • this can occur when
      • the message editing feature is disabled (so the action has not been initiated through the user interface) - safe to ignore
      • the original failed message cannot be loaded - safe to ignore
      • locked headers are changed (not possible through UI) - safe to ignore
      • the message body is empty (not possible through UI) - safe to ignore

@bartekwasielak bartekwasielak marked this pull request as ready for review October 7, 2025 14:15
Copy link
Member

@SzymonPobiega SzymonPobiega left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I proposed some minor changes and links to existing docs

@andreasohlund andreasohlund merged commit 943e025 into master Oct 9, 2025
4 checks passed
@andreasohlund andreasohlund deleted the edit-retry-docs branch October 9, 2025 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants