Skip to content

Clarify how updateMainPools works #163

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Clarify how updateMainPools works #163

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8d52449
Clarify how updateMainPools works
dlebauer Sep 29, 2025
3c81946
Update src/sipnet/sipnet.c
dlebauer Sep 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion src/sipnet/sipnet.c
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
/* SiPnET: Simplified PnET

Author: Bill Sacks wsacks@wisc.edu
Expand Down Expand Up @@ -986,7 +986,7 @@
// This is in addition to [1], source not yet determined (controlled by
// ctx.growthResp)
void vegResp2(double *folResp, double *woodResp, double *growthResp,
double baseFolResp, double /*gpp*/) {

Check failure on line 989 in src/sipnet/sipnet.c

View workflow job for this annotation

GitHub Actions / cpp-linter

src/sipnet/sipnet.c:989:49 [clang-diagnostic-c23-extensions] 

omitting the parameter name in a function definition is a C23 extension
// [TAG:UNKNOWN_PROVENANCE] growthResp
*folResp = baseFolResp *
pow(params.vegRespQ10, (climate->tair - params.psnTOpt) / 10.0);
Expand Down Expand Up @@ -1433,7 +1433,10 @@
*/
void updateMainPools() {
// Update the stocks, with fluxes adjusted for length of time step.
// Note: the soil C pool(s) (envi.soil, envi.fineRootC, envi.CoarseRootC)
// Notes:
// - GPP shows up twice (direct + via NPP --> woodCreation), but
// the math works out to: envi.plantWoodC += NPP_allocation_to_wood − woodLitter.
// - The soil C pool(s) (envi.soil, envi.fineRootC, envi.CoarseRootC)
// were updated in soilDegradation(); also, envi.litter when that is in use.
// And yes, I would love to break that out to maintain more rigor in this
// flow process.
Expand Down
Loading