Skip to content

Conversation

@paul0403
Copy link
Member

Context:
Update to Pylint 4.0.0.
This needs to be coordinated cross the ecosystem, to determine the target pylint version we're going to.
For now, I'm saving the work I have done so far on trying to update catalyst to pylint 4.0.0. I am handing this off to @rniczh

Description of the Change:

Benefits:

Possible Drawbacks:

Related GitHub Issues:

@paul0403 paul0403 added do-not-merge wip PRs that are a Work-In-Progress labels Oct 14, 2025
@rniczh rniczh marked this pull request as ready for review October 23, 2025 17:54
@github-actions
Copy link
Contributor

Hello. You may have forgotten to update the changelog!
Please edit doc/releases/changelog-dev.md on your branch with:

  • A one-to-two sentence description of the change. You may include a small working example for new features.
  • A link back to this PR.
  • Your name (or GitHub username) in the contributors section.

@codecov
Copy link

codecov bot commented Oct 23, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.42%. Comparing base (1b29c70) to head (e2c44f8).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2121      +/-   ##
==========================================
- Coverage   97.43%   97.42%   -0.01%     
==========================================
  Files          92       92              
  Lines       10424    10424              
  Branches     1002     1002              
==========================================
- Hits        10157    10156       -1     
- Misses        210      211       +1     
  Partials       57       57              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@rniczh rniczh removed do-not-merge wip PRs that are a Work-In-Progress labels Oct 28, 2025
@rniczh rniczh requested a review from a team October 28, 2025 14:49
Copy link
Contributor

@dime10 dime10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me, although I'm confused about whether we are or aren't pinning specific versions for black/pylint/isort like in Hongsheng's PR. In the past we have kept up with latest, if we now pin across the ecosystem that's fine too, although Hongsheng's PR doesn't update the check-formatting versions so that will need to be matched.

@paul0403
Copy link
Member Author

This looks good to me, although I'm confused about whether we are or aren't pinning specific versions for black/pylint/isort like in Hongsheng's PR. In the past we have kept up with latest, if we now pin across the ecosystem that's fine too, although Hongsheng's PR doesn't update the check-formatting versions so that will need to be matched.

That PR targets this one 😅 he took over this as part of the dependency update work

@paul0403
Copy link
Member Author

In the past we have kept up with latest, if we now pin across the ecosystem that's fine too

I think the versions are decided at the ecosystem level now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants