- 
                Notifications
    
You must be signed in to change notification settings  - Fork 57
 
Update to Pylint 4.0.0 #2121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Update to Pylint 4.0.0 #2121
Conversation
| 
           Hello. You may have forgotten to update the changelog! 
  | 
    
          Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@            Coverage Diff             @@
##             main    #2121      +/-   ##
==========================================
- Coverage   97.43%   97.42%   -0.01%     
==========================================
  Files          92       92              
  Lines       10424    10424              
  Branches     1002     1002              
==========================================
- Hits        10157    10156       -1     
- Misses        210      211       +1     
  Partials       57       57              ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
  | 
    
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me, although I'm confused about whether we are or aren't pinning specific versions for black/pylint/isort like in Hongsheng's PR. In the past we have kept up with latest, if we now pin across the ecosystem that's fine too, although Hongsheng's PR doesn't update the check-formatting versions so that will need to be matched.
          
 That PR targets this one 😅 he took over this as part of the dependency update work  | 
    
          
 I think the versions are decided at the ecosystem level now.  | 
    
Context:
Update to Pylint 4.0.0.
This needs to be coordinated cross the ecosystem, to determine the target pylint version we're going to.
For now, I'm saving the work I have done so far on trying to update catalyst to pylint 4.0.0. I am handing this off to @rniczh
Description of the Change:
Benefits:
Possible Drawbacks:
Related GitHub Issues: