Add split non commuting pass #2138
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2138 +/- ##
==========================================
- Coverage 97.39% 95.70% -1.70%
==========================================
Files 91 93 +2
Lines 10610 10808 +198
Branches 999 1036 +37
==========================================
+ Hits 10334 10344 +10
- Misses 218 407 +189
+ Partials 58 57 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| if not logger.handlers: | ||
| handler = logging.StreamHandler() | ||
| handler.setLevel(logging.DEBUG) | ||
| formatter = logging.Formatter("%(asctime)s - %(name)s - %(levelname)s - %(message)s") | ||
| handler.setFormatter(formatter) | ||
| logger.addHandler(handler) |
There was a problem hiding this comment.
You should be able to use the PennyLane logging functionality that provides default config already.
I'd change the above to use something similar to
and with usage matchingThere was a problem hiding this comment.
Thanks for the suggestion! But I just removed all the print and debug log from this xdsl pass
| expval_ops_to_remove.append(op) | ||
|
|
||
| if not expval_ops_to_remove: | ||
| print(f"No expvals to remove for group {target_group}") |
There was a problem hiding this comment.
Do we want to print here? Same q with all other print statements
There was a problem hiding this comment.
No, those are debug purpose, I already removed them
| belong to other groups, traces their results to the return statement, | ||
| and removes those return values. | ||
| """ | ||
| print(f"removeGroup: keeping only group {target_group}") |
There was a problem hiding this comment.
No, those are debug purpose, I already removed them
|
Hello. You may have forgotten to update the changelog!
|
|
We aren't ready to have xdsl passes in catalyst right? |
|
@paul0403 Yes, This PR is just for a quick test and fix issues, and we will migrate to PL later |
|
Port to PL PennyLaneAI/pennylane#8531 |
3 participants
Context:
Description of the Change:
Benefits:
Possible Drawbacks:
Related GitHub Issues: