Introducing a Summary of non-failed authentications to results #886
+99
−5
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I have added a summary so when we are password spraying we don't need to be grepping 100s of results to see where the green or purple results are which might indicate something interesting.
I have just implemeted it for the big 3 protocols which are SMB, LDAP and RDP. Some of the code operates slightly different depending on the protocol so the code had to be tweaked at times so is not identical across the 3 at times.
Initially I didn't have the --summary flag required to run it so I had some logical safeguards like only showing a summary if there were more than 10 machines or users. This would be bypassed if a file was being inputted. I also turned it off when modules were being run but maybe I have missed use cases where this might be useful.
I have left these safeguards in for now (which I can remove eventually) with the --summary flag as maybe with the checks in place we could default to using it without the --summary flag if you think it is worth having permanently rather than users requiring more flags to trigger things.
Type of change
Insert an "x" inside the brackets for relevant items (do not delete options)
Screenshots (if appropriate):