spider_plus module enhancement: new 'KEYWORDS' option #913
+53
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…so made changes to the e2s test file
amroes
requested review from
Marshall-Hallenbeck,
NeffIsBack,
mpgn and
zblurx
as code owners
NeffIsBack
requested changes
Sep 4, 2025
nxc/modules/spider_plus.py
Outdated
Comment on lines
516
to
476
| category = "enum" # Added to fix the loading error | ||
| supported_protocols = ["smb"] | ||
| category = CATEGORY.CREDENTIAL_DUMPING |
There was a problem hiding this comment.
Please revert this change
any updates in this PR?
There was a problem hiding this comment.
Unfortunately not yet, there are roughly 50 PRs that need to be reviewed first
Done, you may check it out now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a
KEYWORDSoption to thespider_plusmodule, enabling users to filter files by keywords in their contents (e.g.,-o KEYWORDS=password). The feature enhances targeted file discovery while maintaining backward compatibility with the original module behavior when no keywords are provided. It also:tests/e2e_commands.txtand screenshots for bothKEYWORDSand non-KEYWORDSruns.No issues fixed; this is a new feature.
No new dependencies required.
Type of change
Setup guide for the review
/home/atra/.cache/pypoetry/virtualenvs/netexec-DA4IO4FG-py3.13).git clone https://github.com/amroes/NetExec.gitpoetry installcurl --proto '=https' --tlsv1.2 -sSf https://sh.rustup.rs | shamroes:amroes).source /home/atra/.cache/pypoetry/virtualenvs/netexec-DA4IO4FG-py3.13/bin/activate nxc smb 192.168.252.129 -u amroes -p amroes -M spider_plus -o KEYWORDS=passwordScreenshots
With KEYWORDS:
Without KEYWORDS (shows normal spider_plus usage) :
Checklist
[x] I have ran Ruff against my changes (via poetry: poetry run python -m ruff check . --preview, use --fix to automatically fix what it can)
[x] I have added or updated the tests/e2e_commands.txt file if necessary
[x] New and existing e2e tests pass locally with my changes
[] If reliant on changes of third party dependencies, such as Impacket, dploot, lsassy, etc, I have linked the relevant PRs in those projects
[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[] I have made corresponding changes to the documentation (PR: pending)