Merge pull request #17 from PhantPHP/Collection-contains-item

Collection contains item

Author: lennyrouanet

component/Abstract/Collection.php

@@ -32,6 +32,11 @@ protected function removeItem(mixed $item): self
         return $this;
     }
 
+    protected function containsItem(mixed $item): bool
+    {
+        return array_search($item, $this->items) !== false;
+    }
+
     public function itemsIterator(): \Generator
     {
         foreach ($this->items as $item) {

test/Abstract/CollectionTest.php

@@ -11,6 +11,8 @@ final class CollectionTest extends \PHPUnit\Framework\TestCase
 {
     public function testInterface(): void
     {
+        $value = new Value('Foo');
+
         $collection = new Collection();
 
         $this->assertIsBool($collection->isEmpty());
@@ -19,10 +21,14 @@ public function testInterface(): void
         $this->assertIsInt($collection->getNbItems());
         $this->assertEquals(0, $collection->getNbItems());
 
-        $collection->addValue(
-            new Value('Foo')
+        $this->assertEquals(false, $collection->contains($value));
+
+        $collection->add(
+            $value
         );
 
+        $this->assertEquals(true, $collection->contains($value));
+
         $this->assertEquals(false, $collection->isEmpty());
         $this->assertEquals(1, $collection->getNbItems());
 
@@ -32,15 +38,15 @@ public function testInterface(): void
             $this->assertIsObject($item);
         }
 
-        $collection->removeValue(
-            new Value('Foo')
+        $collection->remove(
+            $value
         );
 
         $this->assertEquals(true, $collection->isEmpty());
         $this->assertEquals(0, $collection->getNbItems());
 
-        $collection->addValue(
-            new Value('Bar')
+        $collection->add(
+            $value
         );
     }
 }

test/Abstract/Fixture/Collection.php

@@ -8,13 +8,18 @@
 
 class Collection extends \Phant\DataStructure\Abstract\Collection
 {
-    public function addValue(Value $item)
+    public function add(Value $item)
     {
         parent::addItem($item);
     }
 
-    public function removeValue(Value $item): self
+    public function remove(Value $item): self
     {
         return parent::removeItem($item);
     }
+
+    public function contains(Value $item): bool
+    {
+        return parent::containsItem($item);
+    }
 }

test/Abstract/Value/VarcharTest.php

@@ -26,4 +26,11 @@ public function testNotCompliant(): void
 
         new Varchar('');
     }
+    
+    public function testAddNonBreakingSpace(): void
+    {
+        $string = (new Varchar('Hello world!'))->addNonBreakingSpace();
+        
+        $this->assertEquals('Hello' . "\xC2\xA0" . 'world!', $string);
+    }
 }