generated from moderneinc/rewrite-recipe-starter
-
Notifications
You must be signed in to change notification settings - Fork 0
Open
Labels
Help wantedExtra attention is neededExtra attention is neededQuestionFurther information is requestedFurther information is requestedmust-have
Description
Although technically out of scope, many people would prefer their assertions to be assertJ-style in their project, either before or after applying the TestNG → Jupiter recipe.
The migration of the expectedExceptions
and expectectedExceptionsMessageRegExp
attributes as well as SkipException
s would create JUnit-assertions/assumptions.
Possible approaches:
- Implement a variant of the existing recipe
- 👍 simple and straightforward
- 👎 creates a second recipe list that would involve lots of duplicated code
- Add input variables to the recipe (list), default being JUnit5-style, input option to use AssertJ
- ❔ how would that be implemented
- 👍 no code duplication
- 👍 ideal performance
- 👎 not straightforward for users, so we would wrap this into two recipe lists which comes down to 1.
- Advise to run the TestNG → AssertJ assertions recipe after
- ❕ need to ensure that recipe does pick up all replacements (this also involves checking some of the more specialized assertion migrations, such as
Assert.assertEqualsNoOrder
) - ❔ how does Add recipes to migrate from TestNG to AssertJ openrewrite/rewrite-testing-frameworks#520 fit into this?
- 👍 straightforward, keeps scope of this recipe
- ❕ need to ensure that recipe does pick up all replacements (this also involves checking some of the more specialized assertion migrations, such as
juherrjuherr and timtebeek
Metadata
Metadata
Assignees
Labels
Help wantedExtra attention is neededExtra attention is neededQuestionFurther information is requestedFurther information is requestedmust-have
Projects
Status
Backlog