Synchronize ShellExec doProcess to prevent race condition on gobblers

thatcomputerguy0101 · thatcomputerguy0101 · commit 19156381dd00 · 2025-11-08T21:15:42.000-05:00
diff --git a/photon-core/src/main/java/org/photonvision/common/util/ShellExec.java b/photon-core/src/main/java/org/photonvision/common/util/ShellExec.java
@@ -136,7 +136,7 @@ public int execute(String command, String workdir, boolean wait, String... args)
         return doProcess(wait, process);
     }
 
-    private int doProcess(boolean wait, Process process) {
+    private synchronized int doProcess(boolean wait, Process process) {
         errorGobbler = new StreamGobbler(process.getErrorStream(), readError);
         outputGobbler = new StreamGobbler(process.getInputStream(), readOutput);
         errorGobbler.start();

Original file line number	Diff line number	Diff line change
`@@ -136,7 +136,7 @@ public int execute(String command, String workdir, boolean wait, String... args)`
`136`	`136`	`return doProcess(wait, process);`
`137`	`137`	`}`
`138`	`138`
`139`		`- private int doProcess(boolean wait, Process process) {`
	`139`	`+ private synchronized int doProcess(boolean wait, Process process) {`
`140`	`140`	`errorGobbler = new StreamGobbler(process.getErrorStream(), readError);`
`141`	`141`	`outputGobbler = new StreamGobbler(process.getInputStream(), readOutput);`
`142`	`142`	`errorGobbler.start();`