Skip to content

Lower AprilTagDetector's maxLineFitMSE #2138

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Lower AprilTagDetector's maxLineFitMSE #2138

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1d81a1a
Lower AprilTagDetector's maxLineFitMSE
Gold856 Oct 18, 2025
1bdfe66
Remove outdated comment
Gold856 Oct 19, 2025
891ba03
Add comment
Gold856 Oct 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion photon-core/src/main/java/org/photonvision/vision/pipeline/AprilTagPipeline.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,7 @@ protected void setPipeParamsImpl() {
// setting them here to prevent upstream changes from changing behavior of the detector
quadParams.maxNumMaxima = 10;
quadParams.criticalAngle = 45 * Math.PI / 180.0;
quadParams.maxLineFitMSE = 10.0f;
quadParams.maxLineFitMSE = 2.5f;
quadParams.minWhiteBlackDiff = 5;
quadParams.deglitch = false;

Expand Down
Loading