Skip to content

Device metrics and control reorganization #2144

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 21 commits into
base: main
Choose a base branch
from
Draft

Device metrics and control reorganization #2144

wants to merge 21 commits into from

Conversation

@DevonRD
Copy link
Contributor

@DevonRD DevonRD commented Oct 22, 2025 •
edited
Loading

Cleans up the settings page by doing the following:

  • Introduces real time metric history to help with diagnostics/monitoring and make the data actually usable
  • Categorizes and cleans up the general information and control buttons

Before and after sample:
image

image

@github-actions github-actions bot added frontend Having to do with PhotonClient and its related items backend Things relating to photon-core and photon-server labels Oct 22, 2025
@samfreund

This comment was marked as resolved.

Sign in to view
@samfreund

This comment was marked as outdated.

Sign in to view
@samfreund

This comment was marked as resolved.

Sign in to view
@samfreund

This comment was marked as resolved.

Sign in to view
@DevonRD

This comment was marked as resolved.

Sign in to view
@DevonRD

This comment was marked as resolved.

Sign in to view
@DevonRD

This comment was marked as resolved.

Sign in to view
@samfreund
Copy link
Member

samfreund commented Oct 24, 2025

We should do some sniffing to see what kind of bandwidth publishing at 1 hz uses.

@samfreund
Copy link
Member

samfreund commented Oct 24, 2025

We should do some sniffing to see what kind of bandwidth publishing at 1 hz uses.

Upon further thinking, it might be all on the robot network, so we'll have to explore how NT handles that.

@samfreund

This comment was marked as resolved.

Sign in to view
@DevonRD

This comment was marked as resolved.

Sign in to view
@DevonRD DevonRD marked this pull request as ready for review November 1, 2025 08:06
@DevonRD DevonRD requested a review from a team as a code owner November 1, 2025 08:06
samfreund
samfreund requested changes Nov 1, 2025
View reviewed changes
Copy link
Member

@samfreund samfreund left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NPU > GPU > ?. Also consider showing bandwidth there as well, although that would have to be implemented as a metric.

On Rubik, GPU accel shows as unknown. In this case, the field should be hidden.

@DevonRD DevonRD marked this pull request as draft November 7, 2025 05:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@samfreund samfreund samfreund requested changes

Requested changes must be addressed to merge this pull request.

Assignees

No one assigned

Labels

backend Things relating to photon-core and photon-server frontend Having to do with PhotonClient and its related items

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@DevonRD @samfreund