Skip to content

Quickbooks Sandbox - Purchase created/Purchase updated #17904

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 4, 2025

Conversation

michelle0927
Copy link
Collaborator

@michelle0927 michelle0927 commented Aug 1, 2025

Follow-up PR to #17625 to update quickbooks_sandbox

Summary by CodeRabbit

  • New Features

    • Introduced "New Purchase Created" and "New Purchase Updated" event sources for the QuickBooks Sandbox environment, allowing users to track purchase events in the sandbox.
  • Chores

    • Updated package and dependency versions for improved compatibility and support.

Copy link
Contributor

coderabbitai bot commented Aug 1, 2025

Walkthrough

Two new source modules for "new-purchase-created" and "new-purchase-updated" events were added to the QuickBooks sandbox component, each adapting existing QuickBooks source logic for the sandbox environment. Additionally, package metadata was updated to increment the package version and update a dependency version.

Changes

Cohort / File(s) Change Summary
QuickBooks Sandbox Source: New Purchase Created
components/quickbooks_sandbox/sources/new-purchase-created/new-purchase-created.mjs
Adds a new sandbox-specific source module for "new-purchase-created" events, adapting common source logic and props.
QuickBooks Sandbox Source: New Purchase Updated
components/quickbooks_sandbox/sources/new-purchase-updated/new-purchase-updated.mjs
Adds a new sandbox-specific source module for "new-purchase-updated" events, reusing and modifying base source logic.
Package Metadata Update
components/quickbooks_sandbox/package.json
Increments package version and updates the @pipedream/quickbooks dependency version.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant SandboxSource
    participant QuickBooksSandboxApp
    participant CommonSourceLogic

    User->>SandboxSource: Triggers new purchase event (created/updated)
    SandboxSource->>QuickBooksSandboxApp: Uses sandbox app instance
    SandboxSource->>CommonSourceLogic: Reuses and adapts common source logic
    SandboxSource-->>User: Emits event with sandbox-specific configuration
Loading

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~7 minutes

Poem

In the sandbox, bunnies hop with cheer,
New sources for purchases now appear!
With versions bumped and logic reused,
QuickBooks events are never confused.
A carrot for each commit, so neat—
These changes make our sandbox sweet! 🥕✨

Note

⚡️ Unit Test Generation is now available in beta!

Learn more here, or try it out under "Finishing Touches" below.

✨ Finishing Touches
  • 📝 Generate Docstrings
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch issue-17625-2

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai generate unit tests to generate unit tests for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

vercel bot commented Aug 1, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs-v2 ⬜️ Ignored (Inspect) Aug 1, 2025 3:49pm
pipedream-docs ⬜️ Ignored (Inspect) Aug 1, 2025 3:49pm
pipedream-docs-redirect-do-not-edit ⬜️ Ignored (Inspect) Aug 1, 2025 3:49pm

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 2

🧹 Nitpick comments (2)
components/quickbooks_sandbox/sources/new-purchase-updated/new-purchase-updated.mjs (1)

6-10: DRY opportunity – duplicated wrapper logic across sources

The destructuring + adjustPropDefinitions pattern is identical to the new-purchase-created source. Consider extracting a tiny helper (buildSandboxSource(commonSource, key)) to avoid copy-paste and keep future maintenance to one place.

components/quickbooks_sandbox/sources/new-purchase-created/new-purchase-created.mjs (1)

6-10: Duplicate wrapper logic – extract a common factory

This module duplicates the exact boilerplate found in new-purchase-updated.mjs. A small factory will make future additions trivial and reduce risk of inconsistencies (e.g. the spread-order bug above).

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between aa09fba and 01113d1.

⛔ Files ignored due to path filters (1)
  • pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml
📒 Files selected for processing (3)
  • components/quickbooks_sandbox/package.json (2 hunks)
  • components/quickbooks_sandbox/sources/new-purchase-created/new-purchase-created.mjs (1 hunks)
  • components/quickbooks_sandbox/sources/new-purchase-updated/new-purchase-updated.mjs (1 hunks)
🧰 Additional context used
🧠 Learnings (4)
📓 Common learnings
Learnt from: GTFalcao
PR: PipedreamHQ/pipedream#15376
File: components/monday/sources/name-updated/name-updated.mjs:6-6
Timestamp: 2025-01-23T03:55:15.166Z
Learning: Source names in Monday.com components don't need to start with "New" if they emit events for updated items (e.g., "Name Updated", "Column Value Updated") rather than new items. This follows the component guidelines exception where the "New" prefix is only required when emits are limited to new items.
📚 Learning: source names in monday.com components don't need to start with "new" if they emit events for updated...
Learnt from: GTFalcao
PR: PipedreamHQ/pipedream#15376
File: components/monday/sources/name-updated/name-updated.mjs:6-6
Timestamp: 2025-01-23T03:55:15.166Z
Learning: Source names in Monday.com components don't need to start with "New" if they emit events for updated items (e.g., "Name Updated", "Column Value Updated") rather than new items. This follows the component guidelines exception where the "New" prefix is only required when emits are limited to new items.

Applied to files:

  • components/quickbooks_sandbox/sources/new-purchase-updated/new-purchase-updated.mjs
  • components/quickbooks_sandbox/sources/new-purchase-created/new-purchase-created.mjs
📚 Learning: in `components/the_magic_drip/sources/common.mjs`, when processing items in `getandprocessdata`, `sa...
Learnt from: GTFalcao
PR: PipedreamHQ/pipedream#14265
File: components/the_magic_drip/sources/common.mjs:35-43
Timestamp: 2024-10-10T19:18:27.998Z
Learning: In `components/the_magic_drip/sources/common.mjs`, when processing items in `getAndProcessData`, `savedIds` is intentionally updated with IDs of both emitted and non-emitted items to avoid emitting retroactive events upon first deployment and ensure only new events are emitted as they occur.

Applied to files:

  • components/quickbooks_sandbox/sources/new-purchase-updated/new-purchase-updated.mjs
📚 Learning: when developing pipedream components, do not add built-in node.js modules like `fs` to `package.json...
Learnt from: jcortes
PR: PipedreamHQ/pipedream#14935
File: components/sailpoint/package.json:15-18
Timestamp: 2024-12-12T19:23:09.039Z
Learning: When developing Pipedream components, do not add built-in Node.js modules like `fs` to `package.json` dependencies, as they are native modules provided by the Node.js runtime.

Applied to files:

  • components/quickbooks_sandbox/package.json
🧬 Code Graph Analysis (2)
components/quickbooks_sandbox/sources/new-purchase-updated/new-purchase-updated.mjs (1)
components/quickbooks_sandbox/sources/new-purchase-created/new-purchase-created.mjs (2)
  • others (6-8)
  • props (9-9)
components/quickbooks_sandbox/sources/new-purchase-created/new-purchase-created.mjs (1)
components/quickbooks_sandbox/sources/new-purchase-updated/new-purchase-updated.mjs (2)
  • others (6-8)
  • props (9-9)
🔇 Additional comments (1)
components/quickbooks_sandbox/package.json (1)

3-3: Compatibility scan clear – remember to smoke-test before publishing
A quick ripgrep across all .mjs imports shows no renamed or removed exports in the jump from @pipedream/quickbooks@0.6.x to @pipedream/quickbooks@^0.7.0. All existing import common from "@pipedream/quickbooks/…" paths resolve as before.

• No breaking import changes detected
• Still run the standard compatibility-check or smoke-test your actions and sources before publishing @pipedream/quickbooks_sandbox@0.3.0

@michelle0927 michelle0927 moved this from Doing to Ready for PR Review in Component (Source and Action) Backlog Aug 1, 2025
Copy link
Collaborator

@jcortes jcortes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @michelle0927 lgtm! Ready for QA!

@jcortes jcortes moved this from Ready for PR Review to Ready for QA in Component (Source and Action) Backlog Aug 1, 2025
@vunguyenhung vunguyenhung moved this from Ready for QA to In QA in Component (Source and Action) Backlog Aug 4, 2025
@vunguyenhung vunguyenhung moved this from In QA to Ready for QA in Component (Source and Action) Backlog Aug 4, 2025
@vunguyenhung vunguyenhung moved this from Ready for QA to In QA in Component (Source and Action) Backlog Aug 4, 2025
@vunguyenhung vunguyenhung moved this from In QA to Ready for Release in Component (Source and Action) Backlog Aug 4, 2025
@vunguyenhung
Copy link
Collaborator

Hi everyone, all test cases are passed! Ready for release!

Test report
https://vunguyenhung.notion.site/Quickbooks-Sandbox-Purchase-created-Purchase-updated-242bf548bb5e81e4a022d445f0ddbd28

@vunguyenhung vunguyenhung merged commit e3c41f7 into master Aug 4, 2025
11 checks passed
@vunguyenhung vunguyenhung deleted the issue-17625-2 branch August 4, 2025 00:45
@github-project-automation github-project-automation bot moved this from Ready for Release to Done in Component (Source and Action) Backlog Aug 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants