Dev feature web docs refactor

.gitignore

@@ -110,3 +110,7 @@ git-journal.fish
 /Set-AssemblyVersion.ps1
 /packages
 *.DoxyFile
+*.meta
+* - Copy.cs
+* - Copy.cs.meta
+/PokemonUnity.WinForm/Resources

PokemonLibrary.sln

@@ -10,6 +10,7 @@ EndProject
 Project("{2150E333-8FDC-42A3-9474-1A3956D46DE8}") = "Solution Items", "Solution Items", "{1909DF4C-3567-4A1F-8BB6-C2DE6584088D}"
 	ProjectSection(SolutionItems) = preProject
 		.editorconfig = .editorconfig
+		PokemonUnity.Application\.editorconfig = PokemonUnity.Application\.editorconfig
 		.gitattributes = .gitattributes
 		.gitignore = .gitignore
 		.gitmodules = .gitmodules

PokemonUnity.Application/.editorconfig

@@ -0,0 +1,13 @@
+[*.cs]
+
+# CS0162: Unreachable code detected
+dotnet_diagnostic.CS0162.severity = silent
+# CS0219: The variable is assigned but its value is never used
+dotnet_diagnostic.CS0219.severity = silent
+dotnet_diagnostic.CS0414.severity = silent
+dotnet_diagnostic.CS0067.severity = silent
+# CS0472: The result of the expression is always 'true'
+dotnet_diagnostic.CS0472.severity = silent
+# CS0618: Entity used is obsolete
+#dotnet_diagnostic.CS0618.severity = silent
+#dotnet_diagnostic.CS0612.severity = silent

PokemonUnity.Application/Character/Bag.cs

@@ -10,19 +10,19 @@
 using PokemonUnity.Character;
 
 namespace PokemonUnity.Character
-{	
+{
 	/// <summary>
 	/// Collection of KeyValuePairs grouped by Items.
-	/// Used in combination with quantity[], 
-	/// one holds the itemId (Key) and the other 
+	/// Used in combination with quantity[],
+	/// one holds the itemId (Key) and the other
 	/// has amount (value).
 	/// </summary>
 	/// I'd feel more comfortable if instead of {get;set;}
 	/// it was a {get;} only, that returned an iqueryable
 	/// ToDo: remove static <see cref="GameVariables.Bag_Items"/>
 	/// so trainerbag can load multiple players (for netplay)
-	/*[System.Obsolete("Something i plan to transistion to; not yet ready for full integration")]
-	public class Bag_Refactor
+	/*[System.Obsolete("Something i plan to transition to; not yet ready for full integration")]
+	public class Bag : PokemonEssentials.Interface.Screen.IBag
 	{
 		#region Variables
 		private List<Items> items { get; set; }
@@ -246,7 +246,7 @@ public KeyValuePair<Items, byte>[] Sort(Order by)
 			}
 			return items.ToArray();
 		}
-		 
+
 		/// <summary>
 		/// If the player has the <see cref="Items.MEGA_BRACELET"/> in their inventory.
 		/// </summary>
@@ -269,7 +269,7 @@ public bool HasMegaBracelet()
 		/// newer gens automatically give at start, so default is true...
 		public bool HasRunningShoes()
 		{
-			//if (!items.Contains(Items.RUNNING_SHOES)) 
+			//if (!items.Contains(Items.RUNNING_SHOES))
 			//	return false;
 
 			return true;
@@ -340,7 +340,7 @@ public bool CanStore(Items item)
 			//Check if item has storage limit
 			//Check if storage limit is met
 			//ToDo: If pocket is full, cannot hold any more items.
-			//ToDo: if individual item capicity is reached, reject add
+			//ToDo: if individual item capacity is reached, reject add
 			if (Kernal.ItemData[item].Pocket == ItemPockets.MISC)
 			{
 				if (Core.MAXPOCKETSIZE[(int)ItemPockets.MISC] == -1) return true;
@@ -368,13 +368,13 @@ public void GetMessageReceive(Items item, IScene scene, int quantity = 1)
 				Message = Game.GameData.Player.Name + " stored it in the~" + Kernal.ItemData[item].Pocket.ToString() + " pocket.";
 			else
 				Message = Game.GameData.Player.Name + " stored them~in the " + Kernal.ItemData[item].Pocket.ToString() + " pocket.";
-			//scene.pbDisplayMessage(Message);
+			//scene.DisplayMessage(Message);
 		}
 
 		public enum Order
 		{
 			Alphabet,
-			Quantity, 
+			Quantity,
 			Category,
 			Price
 		}
@@ -393,7 +393,7 @@ public partial class PokemonBag : PokemonEssentials.Interface.Screen.IBag {
 		private Dictionary<ItemPockets, int> choices;
 
 		public string[] pocketNames { get {
-		  return null; //Game.GameData.pbPocketNames();
+		  return null; //Game.GameData.PocketNames();
 		} }
 		//public ItemPockets pockets { get {
 		//  rearrange();
@@ -429,7 +429,7 @@ public void rearrange() {
 				int nump=numPockets;
 				for (int i = 0; i < @pockets.Length; i++) {
 					foreach (Items item in @pockets[i]) {
-						//ItemPockets p=pbGetPocket(item[0]);
+						//ItemPockets p=GetPocket(item[0]);
 						ItemPockets p=Kernal.ItemData[item].Pocket??ItemPockets.MISC;
 						if ((int)p<=nump) newpockets[(int)p].Add(item);
 					}
@@ -484,9 +484,9 @@ public void setChoice(ItemPockets pocket,int value) {
 		/// Can be retrieved with <see cref="Game.GameData.Bag.registeredItem"/>
 		/// </summary>
 		/// <param name="item"></param>
-		public void pbRegisterKeyItem(Items item) {
+		public void RegisterKeyItem(Items item) {
 			//if (item is String || item is Symbol) {
-			//  item=getID(PBItems,item);
+			//  item=getID(Items,item);
 			//}
 			//if (item == null || item<1) {
 			//  //throw new Exception(Game._INTL("The item number is invalid."));
@@ -501,105 +501,105 @@ public int maxPocketSize(int pocket) {
 			return maxsize.Value;
 		}
 
-		public int pbQuantity(Items item) {
+		public int Quantity(Items item) {
 			//if (item is String || item is Symbol) {
-			//  item=getID(PBItems,item);
+			//  item=getID(Items,item);
 			//}
 			//if (item == null || item<1) {
 			//  //throw new Exception(Game._INTL("The item number is invalid."));
 			//  return 0;
 			//}
-			//ItemPockets pocket=pbGetPocket(item);
+			//ItemPockets pocket=GetPocket(item);
 			int pocket=(int)(Kernal.ItemData[item].Pocket??ItemPockets.MISC);
 			int maxsize=maxPocketSize(pocket);
 			if (maxsize<0) maxsize=@pockets[(int)pocket].Length;
-			return ItemStorageHelper.pbQuantity(@pockets[pocket],maxsize,item);
+			return ItemStorageHelper.Quantity(@pockets[pocket],maxsize,item);
 		}
 
-		public bool pbHasItem (Items item) {
-			return pbQuantity(item)>0;
+		public bool HasItem (Items item) {
+			return Quantity(item)>0;
 		}
 
-		public bool pbDeleteItem(Items item,int qty=1) {
+		public bool DeleteItem(Items item,int qty=1) {
 			//if (item is String || item is Symbol) {
-			//  item=getID(PBItems,item);
+			//  item=getID(Items,item);
 			//}
 			//if (item == null || item<1) {
 			//  //throw new Exception(Game._INTL("The item number is invalid."));
 			//  return false;
 			//}
-			//ItemPockets pocket=pbGetPocket(item);
+			//ItemPockets pocket=GetPocket(item);
 			int pocket=(int)(Kernal.ItemData[item].Pocket??ItemPockets.MISC);
 			int maxsize=maxPocketSize(pocket);
 			if (maxsize<0) maxsize=@pockets[pocket].Length;
-			bool ret=ItemStorageHelper.pbDeleteItem(ref @pockets[pocket],maxsize,item,qty);
+			bool ret=ItemStorageHelper.DeleteItem(ref @pockets[pocket],maxsize,item,qty);
 			if (ret) {
-				if (@registeredItem==item && !pbHasItem(item)) @registeredItem=0;
+				if (@registeredItem==item && !HasItem(item)) @registeredItem=0;
 			}
 			return ret;
 		}
 
-		public bool pbCanStore (Items item,int qty=1) {
+		public bool CanStore (Items item,int qty=1) {
 			//if (item is String || item is Symbol) {
-			//  item=getID(PBItems,item);
+			//  item=getID(Items,item);
 			//}
 			//if (!item || item<1) {
 			//  //throw new Exception(Game._INTL("The item number is invalid."));
 			//  return false;
 			//}
-			//ItemPockets pocket=pbGetPocket(item);
+			//ItemPockets pocket=GetPocket(item);
 			int pocket=(int)(Kernal.ItemData[item].Pocket??ItemPockets.MISC);
 			int maxsize=maxPocketSize(pocket);
 			if (maxsize<0) maxsize=@pockets[pocket].Length+1;
-			return ItemStorageHelper.pbCanStore(
+			return ItemStorageHelper.CanStore(
 				@pockets[pocket],maxsize,Core.BAGMAXPERSLOT,item,qty);
 		}
 
-		public bool pbStoreAllOrNone(Items item,int qty=1) {
-		  //if (item is String || item is Symbol) {
-		  //  item=getID(PBItems,item);
-		  //}
-		  //if (item == null || item<1) {
-		  //  //throw new Exception(Game._INTL("The item number is invalid."));
-		  //  return false;
-		  //}
-		  //ItemPockets pocket=pbGetPocket(item);
-		  int pocket=(int)(Kernal.ItemData[item].Pocket??ItemPockets.MISC);
-		  int maxsize=maxPocketSize(pocket);
-		  if (maxsize<0) maxsize=@pockets[pocket].Length+1;
-		  return ItemStorageHelper.pbStoreItem(ref
-		     @pockets[pocket],maxsize,Core.BAGMAXPERSLOT,item,qty);
+		public bool StoreAllOrNone(Items item,int qty=1) {
+			//if (item is String || item is Symbol) {
+			//  item=getID(Items,item);
+			//}
+			//if (item == null || item<1) {
+			//  //throw new Exception(Game._INTL("The item number is invalid."));
+			//  return false;
+			//}
+			//ItemPockets pocket=GetPocket(item);
+			int pocket=(int)(Kernal.ItemData[item].Pocket??ItemPockets.MISC);
+			int maxsize=maxPocketSize(pocket);
+			if (maxsize<0) maxsize=@pockets[pocket].Length+1;
+			return ItemStorageHelper.StoreItem(ref
+				@pockets[pocket],maxsize,Core.BAGMAXPERSLOT,item,qty);
 		}
 
-		public bool pbStoreItem(Items item,int qty=1) {
+		public bool StoreItem(Items item,int qty=1) {
 			//if (item is String || item is Symbol) {
-			//  item=getID(PBItems,item);
+			//  item=getID(Items,item);
 			//}
 			//if (item == null || item<1) {
 			//  //throw new Exception(Game._INTL("The item number is invalid."));
 			//  return false;
 			//}
-			//ItemPockets pocket=pbGetPocket(item);
+			//ItemPockets pocket=GetPocket(item);
 			int pocket=(int)(Kernal.ItemData[item].Pocket??ItemPockets.MISC);
 			int maxsize=maxPocketSize(pocket);
 			if (maxsize<0) maxsize=@pockets[pocket].Length+1;
-			return ItemStorageHelper.pbStoreItem(ref
+			return ItemStorageHelper.StoreItem(ref
 				@pockets[pocket],maxsize,Core.BAGMAXPERSLOT,item,qty,true);
 		}
 
-		public bool pbChangeItem(Items olditem,Items newitem) {
+		public bool ChangeItem(Items olditem,Items newitem) {
 			//if (olditem is String || olditem is Symbol) {
-			//  olditem=getID(PBItems,olditem);
+			//  olditem=getID(Items,olditem);
 			//}
 			//if (newitem is String || newitem is Symbol) {
-			//  newitem=getID(PBItems,newitem);
+			//  newitem=getID(Items,newitem);
 			//}
 			//if (olditem == null || olditem<1 || newitem == null || newitem<1) {
 			if ((int)olditem<1 || (int)newitem<1) {
 				//throw new Exception(Game._INTL("The item number is invalid."));
 				return false;
 			}
-			//ItemPockets pocket=pbGetPocket(olditem);
+			//ItemPockets pocket=GetPocket(olditem);
 			int pocket=(int)(Kernal.ItemData[olditem].Pocket??ItemPockets.MISC);
 			int maxsize=maxPocketSize(pocket);
 			if (maxsize<0) maxsize=@pockets[pocket].Length;