use a normal list for warns in the db

Author: GreemDev

src/Bot/Systems/Commands/Interaction/Modules/Moderation/WarnCommands.cs

@@ -28,7 +28,7 @@ public async Task<RuntimeResult> ClearWarnsAsync(
         SocketGuildUser member)
     {
         var gd = GetData();
-        var warnCount = gd.Moderation.Warns.RemoveWhere(x => x.Target == member.Id);
+        var warnCount = gd.Moderation.Warns.RemoveAll(x => x.Target == member.Id);
         Db.Save(gd);
 
         var e = Context

src/Bot/Systems/Commands/Text/Modules/Moderation/WarnCommands.cs

@@ -42,7 +42,7 @@ public async Task<ActionResult> ClearWarnsAsync(
         [Remainder, EnsureNotSelf, Description("The member who you want to clear warns for.")]
         SocketGuildUser member)
     {
-        var warnCount = Context.GuildData.Moderation.Warns.RemoveWhere(x => x.Target == member.Id);
+        var warnCount = Context.GuildData.Moderation.Warns.RemoveAll(x => x.Target == member.Id);
         Db.Save(Context.GuildData);
 
         var e = Context

src/Bot/Systems/Database/EntitiesV2/GuildDataV2.cs

@@ -149,7 +149,7 @@ public static GuildDataV2 CreateFrom(IGuild guild)
                 Target = warnV1.User,
                 Reason = warnV1.Reason,
                 Date = warnV1.Date
-            }).ToHashSet()
+            }).ToList()
         },
         StarscriptTables = new StarscriptTables
         {

src/Bot/Systems/Database/EntitiesV2/ModerationData.cs

@@ -4,15 +4,5 @@ public class ModerationData
 {
     public ulong CurrentModActionCase { get; set; }
 
-    public HashSet<WarnV2> Warns { get; set; }
-
-    public bool AddWarn(WarnInitializer warnInitializer)
-    {
-        var warn = new WarnV2();
-        warnInitializer(warn);
-
-        return AddWarn(warn);
-    }
-
-    public bool AddWarn(WarnV2 warn) => Warns.Add(warn);
+    public List<WarnV2> Warns { get; set; }
 }