[FEATURE REQUEST] Allow macro addition to Button class

[martynaskre]

Allow macro addition to Button class

Summary

Currently, Button class does not allow any modifications. Class cannot be extended nor it can be extended with macros.

Why is this needed?

Let's say Powergrid is customised with custom template. Then, the template requires icons with actions buttons. Buttons cannot be hardcoded, because there are different types of them.

Suggested Solution(s)

The most simple solution would be to add Illuminate\Support\Traits\Macroable trait to Button class. This would allow to easily extend class with required methods, e.g. $button->icon('...'). Of course it would still require some refactoring in Helpers/Actions class, which should not be major.

[MarkasCherry]

Yes! This would be so useful!

[luanfreitasdev]

Hello. could you share more examples of how to use it and what we would need to refactor?

[martynaskre]

This repository contains sample project which contains following modifications:

• Button class now implements macroable trait and has additional property named dynamicProperties.
• Actions class now also has dynamicProperties. Dynamic properties are copied when class is constructed. Also this class has method getDynamicProperty.

Dynamic properties can be declared in service providers, e.g. here. After dynamic property is declared, then it can be used as real method, e.g. here.

All things considered, this would not require a lot of modifications and would not cause major code changes. If this solution is good, then I can submit a pull request.

[luanfreitasdev]

This is interesting, would it work as if it were a ? attribute. what else could we do with it?

[martynaskre]

What do you mean by saying ? attribute?

Well, using macros on a button class allows end user to customise template and include custom button properties. There are other possibilities for macros, but this one is bothering me right now.

[luanfreitasdev]

Got it, we can work on this in a PR and add some tests with some real examples and add in the doc

[martynaskre]

I have submitted a PR #726.