Skip to content

Feature: add tmp_remove_nodes method to graph #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 15 commits into from
Feb 5, 2025
Merged

Conversation

Thijss
Copy link
Contributor

@Thijss Thijss commented Jan 23, 2025

Adds a context manager for temporarily removing nodes from the graph.

This can for instance be useful when trying to calculate the shortest path between two nodes without considering certain nodes in the graph.

Signed-off-by: Thijs Baaijen <13253091+Thijss@users.noreply.github.com>
@Thijss Thijss changed the title Feat/tmp remove nodes Feature: add tmp_remove_nodes method to graph Jan 23, 2025
Thijss and others added 3 commits January 23, 2025 16:19
Signed-off-by: Thijs Baaijen <13253091+Thijss@users.noreply.github.com>
Signed-off-by: Thijs Baaijen <13253091+Thijss@users.noreply.github.com>
Signed-off-by: Thijs Baaijen <13253091+Thijss@users.noreply.github.com>
@Thijss Thijss force-pushed the feat/tmp-remove-nodes branch from a918336 to 45780e7 Compare January 23, 2025 15:19
@Thijss Thijss added the v1.1 label Jan 23, 2025
@Thijss Thijss self-assigned this Jan 23, 2025
Thijss and others added 4 commits January 24, 2025 12:40
Co-authored-by: Vincent Koppen <vincent.koppen@alliander.com>
Signed-off-by: Thijs Baaijen <13253091+Thijss@users.noreply.github.com>
Signed-off-by: Thijs Baaijen <13253091+Thijss@users.noreply.github.com>
Signed-off-by: Thijs Baaijen <13253091+Thijss@users.noreply.github.com>
Signed-off-by: Thijs Baaijen <13253091+Thijss@users.noreply.github.com>
@Thijss Thijss force-pushed the feat/tmp-remove-nodes branch from 3a10746 to e0fbce0 Compare January 28, 2025 09:48
@Thijss Thijss changed the base branch from feat/add-all-branches-property to release1_1 January 28, 2025 09:59
Signed-off-by: Thijs Baaijen <13253091+Thijss@users.noreply.github.com>
@Thijss Thijss force-pushed the feat/tmp-remove-nodes branch from a960d8d to 369498b Compare January 28, 2025 10:04
Copy link
Contributor

@vincentkoppen vincentkoppen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, some small points.

@Thijss Thijss force-pushed the feat/tmp-remove-nodes branch 2 times, most recently from e70bae8 to 39730c0 Compare January 28, 2025 15:45
Signed-off-by: Thijs Baaijen <13253091+Thijss@users.noreply.github.com>
@Thijss Thijss force-pushed the feat/tmp-remove-nodes branch from 39730c0 to e81346f Compare January 28, 2025 15:46
Thijss and others added 4 commits January 28, 2025 17:48
Signed-off-by: Thijs Baaijen <13253091+Thijss@users.noreply.github.com>
Signed-off-by: Thijs Baaijen <13253091+Thijss@users.noreply.github.com>
Signed-off-by: Thijs Baaijen <13253091+Thijss@users.noreply.github.com>
@Thijss Thijss force-pushed the feat/tmp-remove-nodes branch from 676fd30 to c93cd2f Compare February 4, 2025 08:46
@Thijss Thijss changed the base branch from release1_1 to main February 5, 2025 14:28
Signed-off-by: Thijs Baaijen <13253091+Thijss@users.noreply.github.com>
@Thijss Thijss enabled auto-merge (squash) February 5, 2025 14:47
Copy link

sonarqubecloud bot commented Feb 5, 2025

@Thijss Thijss merged commit d52e93c into main Feb 5, 2025
19 checks passed
@Thijss Thijss deleted the feat/tmp-remove-nodes branch February 5, 2025 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants