Code quality improvements: Use new enums of dataset and component type#295
Merged
nitbharambe merged 18 commits intomainfrom Jun 20, 2025
Merged
Code quality improvements: Use new enums of dataset and component type#295nitbharambe merged 18 commits intomainfrom
nitbharambe merged 18 commits intomainfrom
Conversation
Signed-off-by: zhen0427 <Zhen.Wang@alliander.com>
mgovers
reviewed
Apr 22, 2025
Co-authored-by: Martijn Govers <martijn.govers@alliander.com> Signed-off-by: Zhen Wang <Zhen.Wang@alliander.com>
|
Member
|
failing sonar cloud seems to be an internal error or another backwards incompatible change |
Signed-off-by: Zhen Wang <Zhen.Wang@alliander.com>
Signed-off-by: zhen0427 <Zhen.Wang@alliander.com>
Signed-off-by: zhen0427 <Zhen.Wang@alliander.com>
Signed-off-by: zhen0427 <Zhen.Wang@alliander.com>
mgovers
reviewed
Jun 13, 2025
mgovers
changed the title
Member
figueroa1395
left a comment
figueroa1395
left a comment
There was a problem hiding this comment.
There are some files that have some strs left, such as in:
test_pandapower_converter_input.pytest_pgm_json_converter.pybase_converter.pypandapower_converter.py- possibly others
In addition, it may also be a good idea to edit the docstrings and replace there the raw strs as well.
This comment was marked as duplicate.
This comment was marked as duplicate.
Sorry, something went wrong.
Signed-off-by: zhen0427 <Zhen.Wang@alliander.com>
Signed-off-by: zhen0427 <Zhen.Wang@alliander.com>
zhen0427
commented
Jun 16, 2025
Signed-off-by: zhen0427 <Zhen.Wang@alliander.com>
Signed-off-by: zhen0427 <Zhen.Wang@alliander.com>
Signed-off-by: zhen0427 <Zhen.Wang@alliander.com>
mgovers
reviewed
Jun 19, 2025
mgovers
reviewed
Jun 19, 2025
Signed-off-by: zhen0427 <Zhen.Wang@alliander.com>
Member
|
@figueroa1395 can you please make CI pass? |
Member
Addressed. Let me quickly review then and if I have nothing to add, I'll ask for your approval. |
Signed-off-by: Santiago Figueroa Manrique <figueroa1395@gmail.com>
Signed-off-by: Santiago Figueroa Manrique <figueroa1395@gmail.com>
Signed-off-by: Santiago Figueroa Manrique <figueroa1395@gmail.com>
nitbharambe
reviewed
Jun 20, 2025
Co-authored-by: Nitish Bharambe <78108900+nitbharambe@users.noreply.github.com> Signed-off-by: Santiago Figueroa Manrique <figueroa1395@gmail.com>
nitbharambe
approved these changes
Jun 20, 2025
Member
nitbharambe
left a comment
nitbharambe
left a comment
There was a problem hiding this comment.
- Checked that pandapower's pgm tests pass.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.