Conversation
Signed-off-by: Nitish Bharambe <nitish.bharambe@alliander.com>
Signed-off-by: Nitish Bharambe <nitish.bharambe@alliander.com>
mgovers
reviewed
May 19, 2025
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
Member
|
The answer was in PGM all along: PowerGridModel/power-grid-model#1002 |
Member
|
See #303 (comment) for what happens without this change (failing sonar cloud build on PRs) |
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
Member
|
do not merge label added to prove sonar cloud test coverage works |
This reverts commit ca3219c. Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
figueroa1395
approved these changes
May 22, 2025
Member
figueroa1395
left a comment
figueroa1395
left a comment
There was a problem hiding this comment.
Sonar coverage works again. LGTM.
Member
proof that it works in ca3219c Test code reverted in b10af5c. Do not merge label removed |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sonar scan shows 0.0 coverage and this warning is shown.
Relates to PowerGridModel/power-grid-model#1002