Process final review comments Signed-off-by: leovsch leo.25.1996@gmail.com

Author: leovsch

src/power_grid_model/validation/_rules.py

@@ -749,7 +749,7 @@ def all_finite(data: SingleDataset, exceptions: dict[ComponentType, list[str]] |
 
 def no_strict_subset_missing(data: SingleDataset, fields: list[str], component_type: ComponentType):
     """
-    Helper function that generates missing value errors if a subset of the supplied fields are missing.
+    Helper function that generates multi field validation errors if a subset of the supplied fields is missing.
     If for an instance of component type all fields are missing or all fields are not missing then,
     no error is returned for that instance.
     In any other case an error for that id is returned.

src/power_grid_model/validation/_validation.py

@@ -546,9 +546,9 @@ def validate_asym_line(data: SingleDataset) -> list[ValidationError]:
     ):
         errors += _all_greater_than_zero(data, ComponentType.asym_line, field)
 
-    errors += _no_strict_subset_missing(data, optional_r_matrix_fields, ComponentType.asym_line)
-    errors += _no_strict_subset_missing(data, optional_x_matrix_fields, ComponentType.asym_line)
+    errors += _no_strict_subset_missing(data, optional_r_matrix_fields + optional_x_matrix_fields, ComponentType.asym_line)
     errors += _no_strict_subset_missing(data, required_c_matrix_fields, ComponentType.asym_line)
+    errors += _no_strict_subset_missing(data, c_fields, ComponentType.asym_line)
     errors += _not_all_missing(data, required_c_matrix_fields + c_fields, ComponentType.asym_line)
 
     return errors

tests/unit/validation/test_input_validation.py

@@ -758,17 +758,14 @@ def test_asym_line_input_data(input_data):
     assert NotGreaterThanError(ComponentType.asym_line, "c0", [55], 0) in validation_errors
     assert NotGreaterThanError(ComponentType.asym_line, "c1", [55], 0) in validation_errors
     assert (
-        MultiFieldValidationError(ComponentType.asym_line, ["r_na", "r_nb", "r_nc", "r_nn"], [56]) in validation_errors
+        MultiFieldValidationError(ComponentType.asym_line, ["r_na", "r_nb", "r_nc", "r_nn", "x_na", "x_nb", "x_nc", "x_nn"], [56, 57]) in validation_errors
     )
     assert (
         MultiFieldValidationError(
             ComponentType.asym_line, ["c_aa", "c_ba", "c_bb", "c_ca", "c_cb", "c_cc", "c0", "c1"], [56]
         )
         in validation_errors
     )
-    assert (
-        MultiFieldValidationError(ComponentType.asym_line, ["x_na", "x_nb", "x_nc", "x_nn"], [57]) in validation_errors
-    )
     assert (
         MultiFieldValidationError(ComponentType.asym_line, ["c_aa", "c_ba", "c_bb", "c_ca", "c_cb", "c_cc"], [58])
         in validation_errors