sonar

Signed-off-by: Santiago Figueroa Manrique <santiago.figueroa.manrique@alliander.com>

Author: figueroa1395

power_grid_model_c/power_grid_model/include/power_grid_model/main_core/update.hpp

@@ -227,8 +227,9 @@ get_all_sequence_idx_map(MainModelState<ComponentContainer> const& state, ConstD
             // The sequence for the independent components is cached (true). For the remaining components, the sequence
             // cannot be cached (false), so the independence flags are inverted to not return an empty sequence when
             // this is the case.
-            bool const component_independence = cached != component_properties.is_independent();
-            if (!component_independence ||
+
+            if (bool const component_independence = cached != component_properties.is_independent();
+                !component_independence ||
                 !std::get<utils::index_of_component<CompType, ComponentTypes...>>(components_to_store)) {
                 return std::vector<Idx2D>{};
             }

power_grid_model_c/power_grid_model/include/power_grid_model/main_model_impl.hpp

@@ -557,7 +557,7 @@ class MainModelImpl<ExtraRetrievableTypes<ExtraRetrievableType...>, ComponentLis
             state_, update_data, 0, components_to_update, update_independence, false);
 
         return [&base_model, &exceptions, &infos, &calculation_fn, &result_data, &update_data,
-                &all_scenarios_sequence = std::as_const(all_scenarios_sequence), components_to_update,
+                &all_scenarios_sequence_ = std::as_const(all_scenarios_sequence), components_to_update,
                 update_independence](Idx start, Idx stride, Idx n_scenarios) {
             assert(n_scenarios <= narrow_cast<Idx>(exceptions.size()));
             assert(n_scenarios <= narrow_cast<Idx>(infos.size()));
@@ -573,7 +573,7 @@ class MainModelImpl<ExtraRetrievableTypes<ExtraRetrievableType...>, ComponentLis
             auto current_scenario_sequence_cache = main_core::utils::SequenceIdx<ComponentType...>{};
             auto [setup, winddown] =
                 scenario_update_restore(model, update_data, components_to_update, update_independence,
-                                        all_scenarios_sequence, current_scenario_sequence_cache, infos);
+                                        all_scenarios_sequence_, current_scenario_sequence_cache, infos);
 
             auto calculate_scenario = MainModelImpl::call_with<Idx>(
                 [&model, &calculation_fn, &result_data, &infos](Idx scenario_idx) {