Merge pull request #941 from PowerGridModel/feature/full-clang-tidy

Full clang-tidy

Author: mgovers

.github/workflows/ci.yml

@@ -53,7 +53,7 @@ jobs:
   clang-tidy:
     uses: "./.github/workflows/clang-tidy.yml"
     with:
-      target: "power_grid_model_api_tests"
+      target: "all"
 
   ci-passed:
     runs-on: ubuntu-latest

.github/workflows/clang-tidy.yml

@@ -65,11 +65,6 @@ jobs:
         run: |
           brew install boost eigen nlohmann-json msgpack-cxx doctest
 
-      - name: Set build target in case of push
-        if: inputs.target == null
-        run: |
-          echo "TARGET=power_grid_model_api_tests" >> $GITHUB_ENV
-
       - name: Set build target in case of workflow dispatch
         if: inputs.target != null
         run: |
@@ -78,4 +73,4 @@ jobs:
       - name: Build
         run: |
           cmake --preset ${{ env.PRESET }}
-          cmake --build --preset ${{ env.PRESET }} --target ${{ env.TARGET }}
+          cmake --build --preset ${{ env.PRESET }} --target ${{ env.TARGET }} -- -k 0

.github/workflows/nightly.yml

@@ -31,7 +31,7 @@ jobs:
   clang-tidy:
     uses: "./.github/workflows/clang-tidy.yml"
     with:
-      target: "all power_grid_model_benchmark_cpp"
+      target: "all"
 
   citations:
     uses: "./.github/workflows/citations.yml"

tests/cpp_validation_tests/test_validation.cpp

@@ -37,13 +37,6 @@ class UnsupportedValidationCase : public PowerGridError {
 
 using nlohmann::json;
 
-auto read_file(std::filesystem::path const& path) {
-    std::ifstream const f{path};
-    std::ostringstream buffer;
-    buffer << f.rdbuf();
-    return buffer.str();
-}
-
 auto read_json(std::filesystem::path const& path) {
     json j;
     std::ifstream f{path};
@@ -77,6 +70,13 @@ OwningDataset load_dataset(std::filesystem::path const& path) {
 // Issue in msgpack, reported in https://github.com/msgpack/msgpack-c/issues/1098
 // May be a Clang Analyzer bug
 #ifndef __clang_analyzer__ // TODO(mgovers): re-enable this when issue in msgpack is fixed
+    auto read_file = [](std::filesystem::path const& read_file_path) {
+        std::ifstream const f{read_file_path};
+        std::ostringstream buffer;
+        buffer << f.rdbuf();
+        return buffer.str();
+    };
+
     Deserializer deserializer{read_file(path), PGM_json};
     auto& writable_dataset = deserializer.get_dataset();
     auto dataset = create_owning_dataset(writable_dataset);