use simple std::views, use simple std::format

Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>

Author: mgovers

power_grid_model_c/power_grid_model/include/power_grid_model/common/exception.hpp

@@ -8,6 +8,7 @@
 #include "enum.hpp"
 
 #include <exception>
+#include <format>
 #include <sstream>
 #include <string>
 
@@ -23,7 +24,7 @@ inline auto to_string(std::integral auto x) { return std::to_string(x); }
 
 class PowerGridError : public std::exception {
   public:
-    void append_msg(std::string_view msg) { msg_ += msg; }
+    void append_msg(std::string_view msg) { msg_ = std::format("{}{}", msg_, msg); }
     char const* what() const noexcept final { return msg_.c_str(); }
 
   private:

power_grid_model_c/power_grid_model/include/power_grid_model/topology.hpp

@@ -296,20 +296,17 @@ class Topology {
         }
 
         // copy all the far-end non-cyclic node, in reverse order
-        // NOLINTNEXTLINE(modernize-use-ranges) // waiting for std::views
-        std::copy_if(dfs_node_copy.crbegin(), dfs_node_copy.crend(), std::back_inserter(dfs_node),
-                     [this](Idx x) { return node_status_[x] == -1; });
+        std::ranges::copy_if(std::views::reverse(dfs_node_copy), std::back_inserter(dfs_node),
+                             [this](Idx x) { return node_status_[x] == -1; });
 
         // copy all cyclic node
         std::vector<Idx> cyclic_node;
-        // NOLINTNEXTLINE(modernize-use-ranges) // waiting for std::views
-        std::copy_if(dfs_node_copy.cbegin(), dfs_node_copy.cend(), std::back_inserter(cyclic_node),
-                     [this](Idx x) { return node_status_[x] == -2; });
+        std::ranges::copy_if(dfs_node_copy, std::back_inserter(cyclic_node),
+                             [this](Idx x) { return node_status_[x] == -2; });
 
         // reorder does not make sense if number of cyclic nodes in a sub graph is smaller than 4
         if (cyclic_node.size() < 4) {
-            // NOLINTNEXTLINE(modernize-use-ranges) // waiting for std::views
-            std::copy(cyclic_node.crbegin(), cyclic_node.crend(), std::back_inserter(dfs_node));
+            std::ranges::copy(std::views::reverse(cyclic_node), std::back_inserter(dfs_node));
             return fill_in;
         }