sonar and test grid asci art in test

Signed-off-by: Jerry Guo <Jerry.Jinfeng.Guo@alliander.com>

Author: Jerry-Jinfeng-Guo

power_grid_model_c/power_grid_model/include/power_grid_model/optimizer/tap_position_optimizer.hpp

@@ -333,7 +333,8 @@ inline auto get_edge_weights(TransformerGraph const& graph) -> TrafoGraphEdgePro
                 "Control side of a transformer should be the relatively closer side to a source.\n");
         }
         if (!is_unreachable(edge_res)) {
-            result.push_back({graph[e].regulated_idx, edge_tgt_rank});
+            // result.push_back({graph[e].regulated_idx, edge_tgt_rank});
+            result.emplace_back(TrafoGraphEdge{graph[e].regulated_idx, edge_tgt_rank});
         }
     }
 

tests/cpp_unit_tests/test_tap_position_optimizer.cpp

@@ -185,6 +185,16 @@ TEST_CASE("Test Transformer ranking") {
     }
 
     SUBCASE("Full grid") {
+        // =====Test Grid=====
+        // ________[0]________
+        // ||           |    |
+        // [1]         [4]--[5]
+        //  |           |    |
+        // [2]          |   [7]
+        //  |          [6]   |
+        // [3]----------|   [8]
+        //  |                |
+        //  L---------------[9]
         TestState state;
         std::vector<NodeInput> nodes{{0, 150e3}, {1, 10e3}, {2, 10e3}, {3, 10e3}, {4, 10e3},
                                      {5, 50e3},  {6, 10e3}, {7, 10e3}, {8, 10e3}, {9, 10e3}};

tests/unit/test_error_handling.py

@@ -289,6 +289,16 @@ def test_handle_invalid_calculation_method_error():
 
 
 def test_transformer_tap_regulator_control_side_not_closer_to_source():
+    # =====Test Grid=====
+    # ________[0]________
+    # ||           |    |
+    # [1]         [4]--[5]
+    #  |           |    |
+    # [2]          |   [7]
+    #  |          [6]   |
+    # [3]----------|   [8]
+    #  |                |
+    #  L---------------[9]
     node_input = initialize_array("input", "node", 10)
     node_input["id"] = [0, 1, 2, 3, 4, 5, 6, 7, 8, 9]
     node_input["u_rated"] = [150e3, 10e3, 10e3, 10e3, 10e3, 50e3, 10e3, 10e3, 10e3, 10e3]