address comments

Signed-off-by: Santiago Figueroa Manrique <santiago.figueroa.manrique@alliander.com>

Author: figueroa1395

power_grid_model_c/power_grid_model/include/power_grid_model/main_core/update.hpp

@@ -247,14 +247,14 @@ SequenceIdx<ComponentTypes...> get_all_sequence_idx_map(MainModelState<Component
 template <class... ComponentTypes, class ComponentContainer>
 SequenceIdx<ComponentTypes...> get_all_sequence_idx_map(MainModelState<ComponentContainer> const& state,
                                                         ConstDataset const& update_data) {
-    // Independence for all components is set to true as permanent updates involve only one scenario.
-    // Flags for all components (not only the ones present in update_data) are set to avoid more expensive checks.
-    constexpr ComponentFlags<ComponentTypes...> all_true = [] {
-        ComponentFlags<ComponentTypes...> result{};
-        std::ranges::fill(result, true);
-        return result;
-    }();
-    return get_all_sequence_idx_map<ComponentTypes...>(state, update_data, 0, all_true);
+    ComponentFlags<ComponentTypes...> components_to_store{};
+    Idx comp_idx{};
+    utils::run_functor_with_all_types_return_void<ComponentTypes...>(
+        [&update_data, &components_to_store, &comp_idx]<typename CompType>() {
+            components_to_store[comp_idx] = (update_data.find_component(CompType::name, false) != invalid_index);
+            ++comp_idx;
+        });
+    return get_all_sequence_idx_map<ComponentTypes...>(state, update_data, 0, components_to_store);
 }
 
 // template to update components

power_grid_model_c/power_grid_model/include/power_grid_model/main_model.hpp

@@ -50,7 +50,6 @@ class MainModel {
     };
     ~MainModel() { impl_.reset(); }
 
-    std::map<std::string, Idx, std::less<>> all_component_count() const { return impl().all_component_count(); }
     void get_indexer(std::string_view component_type, ID const* id_begin, Idx size, Idx* indexer_begin) const {
         impl().get_indexer(component_type, id_begin, size, indexer_begin);
     }

power_grid_model_c/power_grid_model/include/power_grid_model/main_model_impl.hpp

@@ -166,23 +166,6 @@ class MainModelImpl<ExtraRetrievableTypes<ExtraRetrievableType...>, ComponentLis
         return state_.components.template size<CompType>();
     }
 
-    // all component count
-    std::map<std::string, Idx, std::less<>> all_component_count() const {
-        auto const get_comp_count = [this]<typename CT>() {
-            return make_pair(std::string{CT::name}, this->component_count<CT>());
-        };
-        auto const all_count =
-            main_core::utils::run_functor_with_all_types_return_array<ComponentType...>(get_comp_count);
-        std::map<std::string, Idx, std::less<>> result;
-        for (auto const& [name, count] : all_count) {
-            if (count > 0) {
-                // only add if count is greater than 0
-                result[name] = count;
-            }
-        }
-        return result;
-    }
-
     // helper function to get the number of components per type
     std::array<Idx, n_types> get_n_components_per_type() const {
         std::array<Idx, n_types> result{};

tests/cpp_integration_tests/test_main_model.cpp

@@ -1208,10 +1208,6 @@ TEST_CASE("Test main model - runtime dispatch") {
                                     state.asym_node.data());
 
         MainModel model{50.0, input_data};
-        auto const count = model.all_component_count();
-        CHECK(count.at("node") == 3);
-        CHECK(count.at("source") == 2);
-        CHECK(count.find("sym_gen") == count.cend());
 
         // calculation
         model.calculate(get_default_options(symmetric, newton_raphson), sym_result_data);