resolve forward iterator by value instead of const&

Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>

Author: mgovers

.clang-tidy

@@ -67,4 +67,8 @@ WarningsAsErrors: '*'
 HeaderFilterRegex: '.*'
 
 FormatStyle: file
+
+CheckOptions:
+  - key: performance-unnecessary-value-param.AllowedTypes
+  - value: 'ForwardIterator'
 ...

power_grid_model_c/power_grid_model/include/power_grid_model/main_core/input.hpp

@@ -23,8 +23,8 @@ constexpr std::array<Branch3Side, 3> const branch3_sides = {Branch3Side::side_1,
 template <std::derived_from<Base> Component, class ComponentContainer,
           forward_iterator_like<typename Component::InputType> ForwardIterator>
     requires model_component_state_c<MainModelState, ComponentContainer, Component>
-inline void add_component(MainModelState<ComponentContainer>& state, ForwardIterator const& begin,
-                          ForwardIterator const& end, double system_frequency) {
+inline void add_component(MainModelState<ComponentContainer>& state, ForwardIterator begin, ForwardIterator end,
+                          double system_frequency) {
     using ComponentView = std::conditional_t<std::same_as<decltype(*begin), typename Component::InputType const&>,
                                              typename Component::InputType const&, typename Component::InputType>;
 

power_grid_model_c/power_grid_model/include/power_grid_model/main_core/update.hpp

@@ -18,7 +18,7 @@ namespace power_grid_model::main_core::update {
 namespace detail {
 template <component_c Component, forward_iterator_like<typename Component::UpdateType> ForwardIterator, typename Func>
     requires std::invocable<std::remove_cvref_t<Func>, typename Component::UpdateType, Idx2D const&>
-inline void iterate_component_sequence(Func func, ForwardIterator const& begin, ForwardIterator const& end,
+inline void iterate_component_sequence(Func func, ForwardIterator begin, ForwardIterator end,
                                        std::span<Idx2D const> sequence_idx) {
     assert(std::distance(begin, end) >= static_cast<ptrdiff_t>(sequence_idx.size()));
 
@@ -246,8 +246,8 @@ template <component_c Component, class ComponentContainer,
           forward_iterator_like<typename Component::UpdateType> ForwardIterator,
           std::output_iterator<Idx2D> OutputIterator>
     requires model_component_state_c<MainModelState, ComponentContainer, Component>
-inline UpdateChange update_component(MainModelState<ComponentContainer>& state, ForwardIterator const& begin,
-                                     ForwardIterator const& end, OutputIterator changed_it,
+inline UpdateChange update_component(MainModelState<ComponentContainer>& state, ForwardIterator begin,
+                                     ForwardIterator end, OutputIterator changed_it,
                                      std::span<Idx2D const> sequence_idx) {
     using UpdateType = typename Component::UpdateType;
 

power_grid_model_c/power_grid_model/include/power_grid_model/main_model_impl.hpp

@@ -226,8 +226,7 @@ class MainModelImpl<ExtraRetrievableTypes<ExtraRetrievableType...>, ComponentLis
     // if sequence_idx is given, it will be used to load the object instead of using IDs via hash map.
     template <class CompType, cache_type_c CacheType,
               forward_iterator_like<typename CompType::UpdateType> ForwardIterator>
-    void update_component(ForwardIterator const& begin, ForwardIterator const& end,
-                          std::span<Idx2D const> sequence_idx) {
+    void update_component(ForwardIterator begin, ForwardIterator end, std::span<Idx2D const> sequence_idx) {
         constexpr auto comp_index = main_core::utils::index_of_component<CompType, ComponentType...>;
 
         assert(construction_complete_);

tests/cpp_unit_tests/test_tap_position_optimizer.cpp

@@ -1531,17 +1531,18 @@ TEST_CASE("Test RankIterator") {
         tap_changed = rank_iterator.iterate_ranks(regulator_order, mock_lambda, tap_changed);
         iterations_per_rank = rank_iterator.iterations_per_rank();
         rank_index = rank_iterator.rank_index();
+        CHECK_FALSE(tap_changed);
         CHECK(iterations_per_rank[0] == 2);
         CHECK(iterations_per_rank[1] == 4);
         CHECK(iterations_per_rank[2] == 6);
         CHECK(rank_index == 2);
-        CHECK(tap_changed == false);
     }
     SUBCASE("Test tap changed") {
         update = true;
         tap_changed = rank_iterator.iterate_ranks(regulator_order, mock_lambda, tap_changed);
         iterations_per_rank = rank_iterator.iterations_per_rank();
         rank_index = rank_iterator.rank_index();
+        CHECK(tap_changed);
         CHECK(iterations_per_rank[0] == 3);
         CHECK(iterations_per_rank[1] == 0);
         CHECK(iterations_per_rank[2] == 0);
@@ -1553,6 +1554,7 @@ TEST_CASE("Test RankIterator") {
         tap_changed = rank_iterator.iterate_ranks(regulator_order, mock_lambda, tap_changed);
         iterations_per_rank = rank_iterator.iterations_per_rank();
         rank_index = rank_iterator.rank_index();
+        CHECK(tap_changed);
         CHECK(iterations_per_rank[0] == 2);
         CHECK(iterations_per_rank[1] == 4);
         CHECK(iterations_per_rank[2] == 7);