resolve some comments

Signed-off-by: Santiago Figueroa Manrique <figueroa1395@gmail.com>

Author: figueroa1395

power_grid_model_c/power_grid_model/include/power_grid_model/all_components.hpp

@@ -31,16 +31,4 @@ using AllComponents =
     ComponentList<Node, Line, Link, GenericBranch, Transformer, ThreeWindingTransformer, Shunt, Source, SymGenerator,
                   AsymGenerator, SymLoad, AsymLoad, SymPowerSensor, AsymPowerSensor, SymVoltageSensor,
                   AsymVoltageSensor, SymCurrentSensor, AsymCurrentSensor, Fault, TransformerTapRegulator>;
-
-template <typename T>
-concept power_or_current_sensor_c =
-    std::derived_from<T, GenericPowerSensor> || std::derived_from<T, GenericCurrentSensor>;
-
-static_assert(power_or_current_sensor_c<SymPowerSensor>);
-static_assert(power_or_current_sensor_c<AsymPowerSensor>);
-static_assert(power_or_current_sensor_c<SymCurrentSensor>);
-static_assert(power_or_current_sensor_c<AsymCurrentSensor>);
-static_assert(!power_or_current_sensor_c<SymVoltageSensor>);
-static_assert(!power_or_current_sensor_c<AsymVoltageSensor>);
-
 } // namespace power_grid_model

power_grid_model_c/power_grid_model/include/power_grid_model/component/current_sensor.hpp

@@ -156,8 +156,8 @@ template <symmetry_tag current_sensor_symmetry_> class CurrentSensor : public Ge
         output.energized = 1; // current sensor is always energized
         auto i_output = i;
         auto const i_calc_param = calc_param<sym_calc>();
-        auto const& angle_measurement_type = i_calc_param.angle_measurement_type;
-        auto const& i_measured_complex = i_calc_param.measurement.value();
+        auto const angle_measurement_type = i_calc_param.angle_measurement_type;
+        auto const i_measured_complex = i_calc_param.measurement.value();
         if (angle_measurement_type == AngleMeasurementType::local_angle) {
             // I_l = conj(I_g) * exp(i * u_angle)
             // Tranform back the output angle to the local angle frame of reference

power_grid_model_c/power_grid_model/include/power_grid_model/main_core/output.hpp

@@ -312,6 +312,14 @@ constexpr auto output_result(Component const& power_sensor, MainModelState<Compo
         throw MissingCaseForEnumError{std::format("{} output_result()", Component::name), terminal_type};
     }
 }
+template <std::derived_from<GenericPowerSensor> Component, class ComponentContainer,
+          short_circuit_solver_output_type SolverOutputType>
+    requires model_component_state_c<MainModelState, ComponentContainer, Component>
+constexpr auto output_result(Component const& power_or_current_sensor,
+                             MainModelState<ComponentContainer> const& /* state */,
+                             std::vector<SolverOutputType> const& /* solver_output */, Idx const /* obj_seq */) {
+    return power_or_current_sensor.get_null_sc_output();
+}
 
 // output current sensor
 template <std::derived_from<GenericCurrentSensor> Component, class ComponentContainer,
@@ -371,7 +379,7 @@ constexpr auto output_result(Component const& current_sensor, MainModelState<Com
         throw MissingCaseForEnumError{std::format("{} output_result()", Component::name), terminal_type};
     }
 }
-template <power_or_current_sensor_c Component, class ComponentContainer,
+template <std::derived_from<GenericCurrentSensor> Component, class ComponentContainer,
           short_circuit_solver_output_type SolverOutputType>
     requires model_component_state_c<MainModelState, ComponentContainer, Component>
 constexpr auto output_result(Component const& power_or_current_sensor,

tests/cpp_unit_tests/test_current_sensor.cpp

@@ -86,11 +86,8 @@ TEST_CASE("Test current sensor") {
                     sym_current_sensor.get_output<asymmetric_t>(conj(i_asym_local), ComplexValue<asymmetric_t>{1.0});
 
                 // Check symmetric sensor output for symmetric parameters
-                if (angle_measurement_type == AngleMeasurementType::global_angle) {
-                    CHECK(sym_sensor_param.angle_measurement_type == AngleMeasurementType::global_angle);
-                } else {
-                    CHECK(sym_sensor_param.angle_measurement_type == AngleMeasurementType::local_angle);
-                }
+                CHECK(sym_sensor_param.angle_measurement_type == angle_measurement_type);
+
                 // Var(I_Re) ≈ Var(I) * cos^2(pi/4) + Var(θ) * I^2 * sin^2(pi/4)
                 CHECK(sym_sensor_param.measurement.real_component.variance ==
                       doctest::Approx(0.5 * (i_variance_pu + i_angle_variance_pu * i_pu * i_pu)));
@@ -135,11 +132,7 @@ TEST_CASE("Test current sensor") {
                 }
 
                 CHECK(sym_current_sensor.get_terminal_type() == terminal_type);
-                if (angle_measurement_type == AngleMeasurementType::global_angle) {
-                    CHECK(sym_current_sensor.get_angle_measurement_type() == AngleMeasurementType::global_angle);
-                } else {
-                    CHECK(sym_current_sensor.get_angle_measurement_type() == AngleMeasurementType::local_angle);
-                }
+                CHECK(sym_current_sensor.get_angle_measurement_type() == angle_measurement_type);
             }
         }
         SUBCASE("Wrong measured terminal type") {