Skip to content

Commit f9c990c

Browse files
process comment
Signed-off-by: Jerry Guo <Jerry.Jinfeng.Guo@alliander.com>
1 parent b75f6d3 commit f9c990c

File tree

2 files changed

+2
-5
lines changed

2 files changed

+2
-5
lines changed

power_grid_model_c/power_grid_model/include/power_grid_model/common/enum.hpp

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -20,8 +20,6 @@ enum class BranchSide : IntS { from = 0, to = 1 };
2020

2121
enum class Branch3Side : IntS { side_1 = 0, side_2 = 1, side_3 = 2 };
2222

23-
enum class TapSide : IntS { from = 0, to = 1, side_1 = 0, side_2 = 1, side_3 = 2 };
24-
2523
enum class ControlSide : IntS { from = 0, to = 1, side_1 = 0, side_2 = 1, side_3 = 2 };
2624

2725
enum class CalculationType : IntS { power_flow = 0, state_estimation = 1, short_circuit = 2 };

power_grid_model_c/power_grid_model/include/power_grid_model/optimizer/tap_position_optimizer.hpp

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -307,8 +307,6 @@ inline auto get_edge_weights(TransformerGraph const& graph) -> TrafoGraphEdgePro
307307
if (graph[e].regulated_idx == unregulated_idx) {
308308
continue;
309309
}
310-
// control_side, two winding or three winding, is always parallel to the
311-
// source side of the transformer edge
312310
auto const edge_src_rank = vertex_distances[boost::source(e, graph)];
313311
auto const edge_tgt_rank = vertex_distances[boost::target(e, graph)];
314312
auto const edge_res = std::min(edge_src_rank, edge_tgt_rank);
@@ -326,7 +324,8 @@ inline auto get_edge_weights(TransformerGraph const& graph) -> TrafoGraphEdgePro
326324
// | C | B | [A<->B], [C->A], [C->B] |
327325
// | C | C | [A<->B], [A->C], [A->B] |
328326
// In two winding trafo, the edge is always pointing to the control side; in three winding trafo edges, the
329-
// edges are always pointing parallel to the control side: meaning that for delta configuration ABC, the above
327+
// one directional edges are always pointing towards the control side or the node connected to the control
328+
// side via the two directional edge if there exists one. For delta configuration ABC, the above
330329
// situations can happen.
331330
// The logic still holds in meshed grids, albeit operating a more complex graph.
332331
if (edge_src_rank != edge_tgt_rank - 1) {

0 commit comments

Comments
 (0)