Skip to content

Linting and Formatting: add a couple more Ruff checks #1023

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jun 17, 2025

Conversation

Laurynas-Jagutis
Copy link
Member

Adds and fixes SIM errors
Adds and fixes NPY errors

Signed-off-by: Laurynas Jagutis <laurynas.jagutis@alliander.com>
Signed-off-by: Laurynas Jagutis <laurynas.jagutis@alliander.com>
@Laurynas-Jagutis Laurynas-Jagutis self-assigned this Jun 16, 2025
@Laurynas-Jagutis Laurynas-Jagutis added the feature New feature or request label Jun 16, 2025
Signed-off-by: Laurynas Jagutis <laurynas.jagutis@alliander.com>
@Laurynas-Jagutis Laurynas-Jagutis marked this pull request as ready for review June 16, 2025 12:14
Signed-off-by: Laurynas Jagutis <laurynas.jagutis@alliander.com>
Signed-off-by: Laurynas Jagutis <laurynas.jagutis@alliander.com>
Signed-off-by: Laurynas Jagutis <laurynas.jagutis@alliander.com>
Copy link

@Laurynas-Jagutis Laurynas-Jagutis requested a review from mgovers June 16, 2025 13:15
Copy link
Contributor

@figueroa1395 figueroa1395 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. If no more NPY or SIM errors are present and the code generator was run, this is ready in my eyes.

@mgovers mgovers added this pull request to the merge queue Jun 17, 2025
Merged via the queue into main with commit 1e19f7d Jun 17, 2025
31 checks passed
@mgovers mgovers deleted the feature/add-more-ruff-checks branch June 17, 2025 07:46
@nitbharambe nitbharambe changed the title Formatting and Linting: add a couple more Ruff checks Linting and Formatting: add a couple more Ruff checks Jul 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants