Linting and Formatting: adding Pylint checks to Ruff

.pre-commit-config.yaml

@@ -9,7 +9,7 @@ repos:
       - id: reuse
   - repo: https://github.com/astral-sh/ruff-pre-commit
     # Ruff version.
-    rev: v0.11.12
+    rev: v0.12.0
     hooks:
       # Run the linter.
       - id: ruff-check

pyproject.toml

@@ -113,8 +113,10 @@ select = [
     "FURB",
     "FLY",
     "SLOT",
+    "PL",
     "NPY",
 ]
+ignore = ["PLR2004"]
 
 [tool.ruff.lint.isort]
 # Imports that are imported using keyword "as" and are from the same source - are combined.
@@ -123,6 +125,9 @@ combine-as-imports = true
 [tool.ruff.lint.per-file-ignores]
 # Ignore `F811` (redefinition violations) in all examples notebooks since we use redefinition.
 "docs/examples/*.ipynb" = ["F811", "E402"]
+# Pylint was only run in src directory before moving to Ruff
+"tests/*" = ["PL"]
+"setup.py" = ["PL"]
 
 [tool.mypy]
 follow_imports = "silent"

src/power_grid_model/_core/power_grid_core.py

@@ -460,7 +460,7 @@ def destroy_dataset_mutable(self, dataset: MutableDatasetPtr) -> None:  # type:
         pass  # pragma: no cover
 
     @make_c_binding
-    def dataset_mutable_add_buffer(  # type: ignore[empty-body]
+    def dataset_mutable_add_buffer(  # type: ignore[empty-body]  # noqa: PLR0913
         self,
         dataset: MutableDatasetPtr,
         component: str,

src/power_grid_model/_core/power_grid_model.py

@@ -235,7 +235,7 @@ def _handle_errors(self, continue_on_batch_error: bool, batch_size: int, decode_
             decode_error=decode_error,
         )
 
-    def _calculate_impl(
+    def _calculate_impl(  # noqa: PLR0913
         self,
         calculation_type: CalculationType,
         symmetric: bool,
@@ -300,7 +300,7 @@ def _calculate_impl(
 
         return output_data
 
-    def _calculate_power_flow(
+    def _calculate_power_flow(  # noqa: PLR0913
         self,
         *,
         symmetric: bool = True,
@@ -337,7 +337,7 @@ def _calculate_power_flow(
             experimental_features=experimental_features,
         )
 
-    def _calculate_state_estimation(
+    def _calculate_state_estimation(  # noqa: PLR0913
         self,
         *,
         symmetric: bool = True,
@@ -372,7 +372,7 @@ def _calculate_state_estimation(
             experimental_features=experimental_features,
         )
 
-    def _calculate_short_circuit(
+    def _calculate_short_circuit(  # noqa: PLR0913
         self,
         *,
         calculation_method: CalculationMethod | str = CalculationMethod.iec60909,
@@ -406,7 +406,7 @@ def _calculate_short_circuit(
             experimental_features=experimental_features,
         )
 
-    def calculate_power_flow(
+    def calculate_power_flow(  # noqa: PLR0913
         self,
         *,
         symmetric: bool = True,
@@ -505,7 +505,7 @@ def calculate_power_flow(
             tap_changing_strategy=tap_changing_strategy,
         )
 
-    def calculate_state_estimation(
+    def calculate_state_estimation(  # noqa: PLR0913
         self,
         *,
         symmetric: bool = True,
@@ -599,7 +599,7 @@ def calculate_state_estimation(
             decode_error=decode_error,
         )
 
-    def calculate_short_circuit(
+    def calculate_short_circuit(  # noqa: PLR0913
         self,
         *,
         calculation_method: CalculationMethod | str = CalculationMethod.iec60909,

src/power_grid_model/validation/_rules.py

@@ -241,7 +241,7 @@ def not_less_or_equal(val: np.ndarray, *ref: np.ndarray):
     return none_match_comparison(data, component, field, not_less_or_equal, ref_value, NotLessOrEqualError)
 
 
-def all_between(
+def all_between(  # noqa: PLR0913
     data: SingleDataset,
     component: ComponentType,
     field: str,
@@ -281,7 +281,7 @@ def outside(val: np.ndarray, *ref: np.ndarray) -> np.ndarray:
     )
 
 
-def all_between_or_at(
+def all_between_or_at(  # noqa: PLR0913
     data: SingleDataset,
     component: ComponentType,
     field: str,
@@ -331,7 +331,7 @@ def outside(val: np.ndarray, *ref: np.ndarray) -> np.ndarray:
     )
 
 
-def none_match_comparison(
+def none_match_comparison(  # noqa: PLR0913
     data: SingleDataset,
     component: ComponentType,
     field: str,
@@ -554,7 +554,7 @@ def all_valid_enum_values(
     return []
 
 
-def all_valid_associated_enum_values(
+def all_valid_associated_enum_values(  # noqa: PLR0913
     data: SingleDataset,
     component: ComponentType,
     field: str,

src/power_grid_model/validation/_validation.py

@@ -279,7 +279,7 @@ def _process_power_sigma_and_p_q_sigma(
         power_sigma[mask] = np.nansum(q_sigma[mask], axis=asym_axes)
 
 
-def validate_required_values(
+def validate_required_values(  # noqa: PLR0915
     data: SingleDataset, calculation_type: CalculationType | None = None, symmetric: bool = True
 ) -> list[MissingValueError]:
     """
@@ -631,7 +631,7 @@ def validate_branch3(data: SingleDataset, component: ComponentType) -> list[Vali
     return errors
 
 
-def validate_three_winding_transformer(data: SingleDataset) -> list[ValidationError]:
+def validate_three_winding_transformer(data: SingleDataset) -> list[ValidationError]:  # noqa: PLR0915
     errors = validate_branch3(data, ComponentType.three_winding_transformer)
     errors += _all_greater_than_zero(data, ComponentType.three_winding_transformer, "u1")
     errors += _all_greater_than_zero(data, ComponentType.three_winding_transformer, "u2")