Skip to content

Docs: unsupported floating grids in asymmetric calculations#1367

Merged
TonyXiang8787 merged 18 commits intomainfrom
feature/document-float-grid
May 3, 2026
Merged

Docs: unsupported floating grids in asymmetric calculations#1367
TonyXiang8787 merged 18 commits intomainfrom
feature/document-float-grid

Conversation

@zhen0427
Copy link
Copy Markdown
Member

@zhen0427 zhen0427 commented Apr 14, 2026

Documented that

  • asymmetric power flow requires a grounded network (via Yn/Dn transformer or shunt) and
  • current short circuit calculations are incorrectly implemented in the abc domain and should be handled in the sequence (0-1-2) domain, with a note added for a future feature request.

@zhen0427
add cal lim
6ac35a9 
Signed-off-by: zhen0427 <Zhen.Wang@alliander.com>
@zhen0427 zhen0427 added the documentation Improvements or additions to documentation label Apr 14, 2026
figueroa1395
figueroa1395 reviewed Apr 14, 2026
View reviewed changes
Comment thread docs/user_manual/calculations.md Outdated
Comment thread docs/user_manual/calculations.md Outdated
Comment thread docs/user_manual/calculations.md Outdated
Comment thread src/power_grid_model/_core/enum.py
@mgovers mgovers changed the title Document unsupported floating grids in asymmetric calculations Docs: unsupported floating grids in asymmetric calculations Apr 15, 2026
zhen0427 added 3 commits April 22, 2026 10:33
@zhen0427
Merge branch 'main' into feature/document-float-grid
fbf00a1
@zhen0427
further improvements based on test results
be7983e 
Signed-off-by: zhen0427 <Zhen.Wang@alliander.com>
@zhen0427
minor changes
a0613a2 
Signed-off-by: zhen0427 <Zhen.Wang@alliander.com>
mgovers
mgovers reviewed Apr 23, 2026
View reviewed changes
Comment thread docs/algorithms/pf-algorithms.md Outdated
Comment thread docs/user_manual/calculations.md Outdated
figueroa1395
figueroa1395 reviewed Apr 24, 2026
View reviewed changes
Comment thread docs/user_manual/calculations.md Outdated
figueroa1395
figueroa1395 reviewed Apr 24, 2026
View reviewed changes
Comment thread docs/user_manual/calculations.md Outdated
nitbharambe
nitbharambe reviewed Apr 28, 2026
View reviewed changes
Comment thread docs/user_manual/calculations.md Outdated
zhen0427 and others added 3 commits April 29, 2026 09:06
@zhen0427 @figueroa1395
Update docs/user_manual/calculations.md
9341f25 
Co-authored-by: Santiago Figueroa Manrique <figueroa1395@gmail.com>
Signed-off-by: Zhen Wang <Zhen.Wang@alliander.com>
@zhen0427 @mgovers
Update docs/algorithms/pf-algorithms.md
c2c2c18 
Co-authored-by: Martijn Govers <martijn.govers@alliander.com>
Signed-off-by: Zhen Wang <Zhen.Wang@alliander.com>
@zhen0427
Merge branch 'main' into feature/document-float-grid
3ec982e
mgovers
mgovers reviewed Apr 29, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@mgovers mgovers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2 nitpicks, feel free to ignore them

Comment thread docs/algorithms/sc-algorithms.md Outdated
Comment thread docs/user_manual/calculations.md Outdated
zhen0427 added 2 commits April 29, 2026 13:47
@zhen0427
push to clear my mind
19245d8 
Signed-off-by: zhen0427 <Zhen.Wang@alliander.com>
@zhen0427
major revision
8a12755 
Signed-off-by: zhen0427 <Zhen.Wang@alliander.com>
figueroa1395
figueroa1395 reviewed Apr 30, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@figueroa1395 figueroa1395 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very clear documentation. Just some minor things left.

Comment thread docs/algorithms/sc-algorithms.md Outdated
Comment thread docs/user_manual/calculations.md Outdated
Comment thread docs/user_manual/calculations.md Outdated
nitbharambe
nitbharambe reviewed Apr 30, 2026
View reviewed changes
Comment thread docs/user_manual/calculations.md Outdated
nitbharambe
nitbharambe reviewed Apr 30, 2026
View reviewed changes
Comment thread docs/user_manual/calculations.md Outdated
zhen0427 and others added 8 commits April 30, 2026 11:13
@zhen0427 @figueroa1395
Update docs/user_manual/calculations.md
888dbc5 
Co-authored-by: Santiago Figueroa Manrique <figueroa1395@gmail.com>
Signed-off-by: Zhen Wang <Zhen.Wang@alliander.com>
@zhen0427 @figueroa1395
Update docs/user_manual/calculations.md
1be7c05 
Co-authored-by: Santiago Figueroa Manrique <figueroa1395@gmail.com>
Signed-off-by: Zhen Wang <Zhen.Wang@alliander.com>
@zhen0427 @nitbharambe
Update docs/user_manual/calculations.md
6e35f3e 
Co-authored-by: Nitish Bharambe <78108900+nitbharambe@users.noreply.github.com>
Signed-off-by: Zhen Wang <Zhen.Wang@alliander.com>
@zhen0427
a minor change
a719a80 
Signed-off-by: zhen0427 <Zhen.Wang@alliander.com>
@zhen0427
fix CI
dfe7068 
Signed-off-by: zhen0427 <Zhen.Wang@alliander.com>
@zhen0427
fix
12ac49e 
Signed-off-by: zhen0427 <Zhen.Wang@alliander.com>
@zhen0427
markdownlint
f364abc 
Signed-off-by: zhen0427 <Zhen.Wang@alliander.com>
@zhen0427
Merge branch 'main' into feature/document-float-grid
738e28d
@zhen0427 zhen0427 marked this pull request as ready for review May 1, 2026 08:31
nitbharambe
nitbharambe reviewed May 1, 2026
View reviewed changes
Comment thread docs/algorithms/sc-algorithms.md Outdated
nitbharambe
nitbharambe reviewed May 1, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@nitbharambe nitbharambe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One comment. Rest LGTM

@TonyXiang8787 @nitbharambe
Apply suggestion from @nitbharambe
5487b9f 
Co-authored-by: Nitish Bharambe <78108900+nitbharambe@users.noreply.github.com>
Signed-off-by: Tony Xiang <19280867+TonyXiang8787@users.noreply.github.com>
@TonyXiang8787 TonyXiang8787 enabled auto-merge May 3, 2026 10:17
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented May 3, 2026

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@TonyXiang8787 TonyXiang8787 added this pull request to the merge queue May 3, 2026
Merged via the queue into main with commit 1b5b3aa May 3, 2026
34 checks passed
@TonyXiang8787 TonyXiang8787 deleted the feature/document-float-grid branch May 3, 2026 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mgovers mgovers mgovers left review comments

@figueroa1395 figueroa1395 figueroa1395 left review comments

@nitbharambe nitbharambe nitbharambe left review comments

@TonyXiang8787 TonyXiang8787 TonyXiang8787 approved these changes

Assignees

No one assigned

Labels

documentation Improvements or additions to documentation

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@zhen0427 @mgovers @TonyXiang8787 @figueroa1395 @nitbharambe