Step-up transformer tap changer support: feature branch #826
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jerry Guo <Jerry.Jinfeng.Guo@alliander.com>
Signed-off-by: Jerry Guo <Jerry.Jinfeng.Guo@alliander.com>
Jerry-Jinfeng-Guo
added
feature
…eature/updated-transformer-ranking
Signed-off-by: Nitish Bharambe <nitish.bharambe@alliander.com>
Signed-off-by: Nitish Bharambe <nitish.bharambe@alliander.com>
…eature/regulator-unique-validation
…validation Feature / add unique regulators condition to data validator
Signed-off-by: Jerry Guo <Jerry.Jinfeng.Guo@alliander.com>
…eature/updated-transformer-ranking
Signed-off-by: Jerry Guo <Jerry.Jinfeng.Guo@alliander.com>
…er-ranking Feature / Updated transformer weight before transformer ranking
Signed-off-by: Jerry Guo <Jerry.Jinfeng.Guo@alliander.com>
…eature/step-up-trafo-tap-changer-ranking
Signed-off-by: Jerry Guo <Jerry.Jinfeng.Guo@alliander.com>
Signed-off-by: Jerry Guo <Jerry.Jinfeng.Guo@alliander.com>
Signed-off-by: Jerry Guo <Jerry.Jinfeng.Guo@alliander.com>
Signed-off-by: Jerry Guo <Jerry.Jinfeng.Guo@alliander.com>
Signed-off-by: Jerry Guo <Jerry.Jinfeng.Guo@alliander.com>
Jerry-Jinfeng-Guo
requested review from
mgovers,
nitbharambe,
petersalemink95,
TonyXiang8787 and
figueroa1395
Signed-off-by: Jerry Guo <Jerry.Jinfeng.Guo@alliander.com>
mgovers
reviewed
Mar 7, 2025
..._grid_model_c/power_grid_model/include/power_grid_model/optimizer/tap_position_optimizer.hpp
Outdated
Show resolved
Hide resolved
..._grid_model_c/power_grid_model/include/power_grid_model/optimizer/tap_position_optimizer.hpp
Outdated
Show resolved
Hide resolved
..._grid_model_c/power_grid_model/include/power_grid_model/optimizer/tap_position_optimizer.hpp
Outdated
Show resolved
Hide resolved
Signed-off-by: Jerry Guo <Jerry.Jinfeng.Guo@alliander.com>
Signed-off-by: Jerry Guo <Jerry.Jinfeng.Guo@alliander.com>
Signed-off-by: Jerry Guo <Jerry.Jinfeng.Guo@alliander.com>
power_grid_model_c/power_grid_model/include/power_grid_model/common/enum.hpp
Outdated
Show resolved
Hide resolved
..._grid_model_c/power_grid_model/include/power_grid_model/optimizer/tap_position_optimizer.hpp
Outdated
Show resolved
Hide resolved
..._grid_model_c/power_grid_model/include/power_grid_model/optimizer/tap_position_optimizer.hpp
Show resolved
Hide resolved
..._grid_model_c/power_grid_model/include/power_grid_model/optimizer/tap_position_optimizer.hpp
Show resolved
Hide resolved
Signed-off-by: Jerry Guo <Jerry.Jinfeng.Guo@alliander.com>
Signed-off-by: Jerry Guo <6221579+Jerry-Jinfeng-Guo@users.noreply.github.com>
Signed-off-by: Jerry Guo <Jerry.Jinfeng.Guo@alliander.com>
figueroa1395
previously approved these changes
Mar 12, 2025
mgovers
previously approved these changes
Mar 13, 2025
..._grid_model_c/power_grid_model/include/power_grid_model/optimizer/tap_position_optimizer.hpp
Outdated
Show resolved
Hide resolved
…ptimizer/tap_position_optimizer.hpp Co-authored-by: Martijn Govers <martijn.govers@alliander.com> Signed-off-by: Jerry Guo <6221579+Jerry-Jinfeng-Guo@users.noreply.github.com>
Jerry-Jinfeng-Guo
dismissed stale reviews from mgovers and figueroa1395
via
e911275
|
nitbharambe
approved these changes
Mar 13, 2025
Jerry-Jinfeng-Guo
deleted the
feature/step-up-transformer-tap-changer-support
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the feature branch for step-up transformer tap changer support. Closes #662.
Dedicated tests:
Feature additions (w/ unit tests):
1to0[Feature / Updated transformer weight before transformer ranking #698]