Step-up transformer tap changer support: feature branch

docs/user_manual/calculations.md

@@ -628,7 +628,7 @@ Power flow calculations that take the behavior of these regulators into account
 
 The following control logic is used:
 
-- Regulated transformers are ranked according to how close they are to {hoverxreftooltip}`sources <user_manual/components:source>` in terms of the amount of transformers inbetween.
+- Regulated transformers are ranked according to how close they are to {hoverxreftooltip}`sources <user_manual/components:source>` in terms of the amount of regulated transformers inbetween.
   - Transformers are regulated in order according to their ranks.
 - Initialize all transformers to their starting tap position (see {hoverxreftooltip}`user_manual/calculations:Initialization and exploitation of regulated transformers`)
 - Find the optimal state using the following procedure

power_grid_model_c/power_grid_model/include/power_grid_model/common/exception.hpp

@@ -196,6 +196,13 @@ class AutomaticTapCalculationError : public PowerGridError {
     }
 };
 
+class AutomaticTapInputError : public PowerGridError {
+  public:
+    AutomaticTapInputError(std::string const& msg) {
+        append_msg("Automatic tap changer has invalid configuration. " + msg); // NOSONAR
+    }
+};
+
 class IDWrongType : public PowerGridError {
   public:
     explicit IDWrongType(ID id) { append_msg("Wrong type for object with id " + detail::to_string(id) + '\n'); }

power_grid_model_c/power_grid_model/include/power_grid_model/main_core/input.hpp

@@ -137,28 +137,8 @@ inline void add_component(MainModelState<ComponentContainer>& state, ForwardIter
                 }
             }();
 
-            if (regulated_object_idx.group == get_component_type_index<Transformer>(state)) {
-                auto const& regulated_object = get_component<Transformer>(state, regulated_object_idx);
-
-                auto const non_tap_side =
-                    regulated_object.tap_side() == BranchSide::from ? BranchSide::to : BranchSide::from;
-                if (get_component<Node>(state, regulated_object.node(regulated_object.tap_side())).u_rated() <
-                    get_component<Node>(state, regulated_object.node(non_tap_side)).u_rated()) {
-                    throw AutomaticTapCalculationError(id);
-                }
-            } else if (regulated_object_idx.group == get_component_type_index<ThreeWindingTransformer>(state)) {
-                auto const& regulated_object = get_component<ThreeWindingTransformer>(state, regulated_object_idx);
-                auto const tap_side_u_rated =
-                    get_component<Node>(state, regulated_object.node(regulated_object.tap_side())).u_rated();
-                for (auto const side : branch3_sides) {
-                    if (side == regulated_object.tap_side()) {
-                        continue;
-                    }
-                    if (tap_side_u_rated < get_component<Node>(state, regulated_object.node(side)).u_rated()) {
-                        throw AutomaticTapCalculationError(id);
-                    }
-                }
-            } else {
+            if (regulated_object_idx.group != get_component_type_index<Transformer>(state) &&
+                regulated_object_idx.group != get_component_type_index<ThreeWindingTransformer>(state)) {
                 throw InvalidRegulatedObject(input.regulated_object, Component::name);
             }
 

src/power_grid_model/_core/error_handling.py

@@ -14,6 +14,7 @@
 from power_grid_model._core.power_grid_core import power_grid_core as pgc
 from power_grid_model.errors import (
     AutomaticTapCalculationError,
+    AutomaticTapInputError,
     ConflictID,
     ConflictVoltage,
     IDNotFound,
@@ -71,6 +72,8 @@
 _AUTOMATIC_TAP_CALCULATION_ERROR_RE = re.compile(
     r"Automatic tap changing regulator with tap_side at LV side is not supported. Found at id (-?\d+)\n"
 )
+_AUTOMATIC_TAP_INPUT_ERROR_RE = re.compile(r"Automatic tap changer has invalid configuration")
+
 _ID_WRONG_TYPE_RE = re.compile(r"Wrong type for object with id (-?\d+)\n")
 _INVALID_CALCULATION_METHOD_RE = re.compile(r"The calculation method is invalid for this calculation!")
 _INVALID_SHORT_CIRCUIT_PHASE_OR_TYPE_RE = re.compile(r"short circuit type")  # multiple different flavors
@@ -95,6 +98,7 @@
     _INVALID_MEASURED_OBJECT_RE: InvalidMeasuredObject,
     _INVALID_REGULATED_OBJECT_RE: InvalidRegulatedObject,
     _AUTOMATIC_TAP_CALCULATION_ERROR_RE: AutomaticTapCalculationError,
+    _AUTOMATIC_TAP_INPUT_ERROR_RE: AutomaticTapInputError,
     _ID_WRONG_TYPE_RE: IDWrongType,
     _INVALID_CALCULATION_METHOD_RE: InvalidCalculationMethod,
     _INVALID_SHORT_CIRCUIT_PHASE_OR_TYPE_RE: InvalidShortCircuitPhaseOrType,

src/power_grid_model/errors.py

@@ -97,6 +97,10 @@ class AutomaticTapCalculationError(PowerGridError):
     """Automatic tap changer with tap at LV side is unsupported for automatic tap changing calculation."""
 
 
+class AutomaticTapInputError(PowerGridError):
+    """Automatic tap changer has invalid configuration."""
+
+
 class InvalidShortCircuitPhaseOrType(PowerGridError):
     """Invalid (combination of) short circuit types and phase(s) provided."""
 

src/power_grid_model/validation/validation.py

@@ -950,6 +950,7 @@ def validate_regulator(data: SingleDataset, component: ComponentType) -> list[Va
 def validate_transformer_tap_regulator(data: SingleDataset) -> list[ValidationError]:
     errors = validate_regulator(data, ComponentType.transformer_tap_regulator)
     errors += _all_boolean(data, ComponentType.transformer_tap_regulator, "status")
+    errors += _all_unique(data, ComponentType.transformer_tap_regulator, "regulated_object")
     errors += _all_valid_enum_values(
         data, ComponentType.transformer_tap_regulator, "control_side", [BranchSide, Branch3Side]
     )

tests/cpp_unit_tests/test_optimizer.hpp

@@ -146,7 +146,7 @@ static_assert(std::convertible_to<decltype(stub_const_dataset_update), ConstData
 
 constexpr auto strategies = [] {
     using enum OptimizerStrategy;
-    return std::array{any, global_minimum, global_maximum, local_minimum, local_maximum};
+    return std::array{any, local_maximum, local_minimum, global_maximum, global_minimum};
 }();
 
 constexpr auto calculation_methods = [] {