Skip to content

Data validator: add unique regulators condition to #829

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Nov 13, 2024
Merged

Data validator: add unique regulators condition to #829

merged 6 commits into from
Nov 13, 2024

Conversation

nitbharambe
Copy link
Member

No description provided.

mgovers and others added 4 commits November 11, 2024 09:06
@mgovers
add check-blocking-labels github action
e738280 
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
@mgovers
Merge branch 'main' into feature/add-do-not-merge-check
1c44076
@mgovers
Merge pull request #827 from PowerGridModel/feature/add-do-not-merge-…
004421a 
…check

[Feature] add check-blocking-labels github action
@nitbharambe
add case to validator
a68f7de 
Signed-off-by: Nitish Bharambe <nitish.bharambe@alliander.com>
@nitbharambe nitbharambe changed the base branch from main to feature/step-up-transformer-tap-changer-support November 11, 2024 14:36
@nitbharambe
spell error
a1d8a37 
Signed-off-by: Nitish Bharambe <nitish.bharambe@alliander.com>
@nitbharambe nitbharambe marked this pull request as ready for review November 11, 2024 15:39
figueroa1395
figueroa1395 reviewed Nov 13, 2024
View reviewed changes
Copy link
Contributor

@figueroa1395 figueroa1395 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, however, don't we also have to do some check on the core? EDIT: They exist:

power-grid-model/power_grid_model_c/power_grid_model/include/power_grid_model/main_core/input.hpp

Lines 171 to 177 in eeb5749

// Make sure that each regulated object has at most one regulator
const std::unordered_set<Idx2D, Idx2DHash> unique_regulated_objects(regulated_objects.begin(),
regulated_objects.end());
if (unique_regulated_objects.size() != regulated_objects.size()) {
// There are duplicates
throw DuplicativelyRegulatedObject{};
}

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@TonyXiang8787 TonyXiang8787 merged commit d7f9b46 into feature/step-up-transformer-tap-changer-support Nov 13, 2024
27 checks passed
@TonyXiang8787 TonyXiang8787 deleted the feature/regulator-unique-validation branch November 13, 2024 10:49
@Jerry-Jinfeng-Guo Jerry-Jinfeng-Guo mentioned this pull request Nov 14, 2024
Merged
8 tasks
@Jerry-Jinfeng-Guo Jerry-Jinfeng-Guo mentioned this pull request Mar 17, 2025
Merged
@Jerry-Jinfeng-Guo Jerry-Jinfeng-Guo added the feature New feature or request label May 13, 2025
@Jerry-Jinfeng-Guo Jerry-Jinfeng-Guo changed the title Feature / add unique regulators condition to data validator Data validator: add unique regulators condition to May 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@figueroa1395 figueroa1395 figueroa1395 approved these changes

Assignees

@nitbharambe nitbharambe

Labels
feature New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@nitbharambe @figueroa1395 @Jerry-Jinfeng-Guo @TonyXiang8787 @mgovers