Skip to content

Keep only important integration tests: step 1 #833

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 16 commits into from
Nov 25, 2024
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 0 additions & 31 deletions tests/cpp_integration_tests/test_main_model.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -372,37 +372,6 @@ TEST_CASE("Test main model - individual output (asymmetric)") {
auto const res = main_model.calculate<power_flow_t, asymmetric_t>(
get_default_options(asymmetric, CalculationMethod::newton_raphson));

/*
TODO:
- test node
- test line
- test link
- test source
- test sym load
- test asym load
- test shunt
*/

SUBCASE("Node, asym output") { // TODO(mgovers): p and q not tested in power_flow/dummy-test/sym_output.json
main_model.output_result<Node>(res, state.asym_node);
main_model.output_result<Appliance>(res, state.asym_appliance);

CHECK(state.asym_node[0].u_pu(0) == doctest::Approx(1.05));
CHECK(state.asym_node[1].u_pu(1) == doctest::Approx(test::u1));
CHECK(state.asym_node[2].u_pu(2) == doctest::Approx(test::u1));

CHECK(state.asym_node[0].p(0) == doctest::Approx(state.asym_appliance[0].p(0)).scale(1e3));
CHECK(state.asym_node[1].p(1) == doctest::Approx(0.0).scale(1e3));
CHECK(state.asym_node[2].p(2) == doctest::Approx(state.asym_appliance[1].p(2) - state.asym_appliance[2].p(2) -
state.asym_appliance[3].p(2))
.scale(1e3));
CHECK(state.asym_node[0].q(2) == doctest::Approx(state.asym_appliance[0].q(2)).scale(1e3));
CHECK(state.asym_node[1].q(1) == doctest::Approx(0.0).scale(1e3));
CHECK(state.asym_node[2].q(0) == doctest::Approx(state.asym_appliance[1].q(0) - state.asym_appliance[2].q(0) -
state.asym_appliance[3].q(0))
.scale(1e3));
}

SUBCASE("AsymVoltageSensor, asym output") { // TODO(mgovers): sensor output for powerflow calculations are not
// tested elsewhere => validation case
main_model.output_result<Node>(res, state.asym_node);
Expand Down