Skip to content

Observability: internal voltage count check #837

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 21, 2024

Conversation

nitbharambe
Copy link
Member

@nitbharambe nitbharambe commented Nov 20, 2024

Relates to #508

There was a bug in voltage measurement observability check. By the virture of conditions, the situation never results in a incorrect behavior and the tests cover these cases.

Earlier (naming convention used as per issue here):

if (n_voltage_sensor + n_voltage_phasor_sensor < 1):
	throw NotObservableError{}

Corrected:

if (n_voltage_sensor < 1):
	throw NotObservableError{}
n_voltage_sensor n_voltage_magnitude_sensor n_voltage_phasor_sensor result
2 1 1 pass both before/after
1 0 1 (never possible)
1 1 0 throws both before/after
0 0 0 throws both before/after

Added a fix, renamed to how it is in issue to avoid ambiguity.

Signed-off-by: Nitish Bharambe <nitish.bharambe@alliander.com>
@nitbharambe nitbharambe changed the title Observability internal bug Fix / Observability internal voltage count check Nov 20, 2024
@nitbharambe nitbharambe marked this pull request as ready for review November 21, 2024 08:28
@TonyXiang8787 TonyXiang8787 added this pull request to the merge queue Nov 21, 2024
Merged via the queue into main with commit 1f174e3 Nov 21, 2024
27 checks passed
@TonyXiang8787 TonyXiang8787 deleted the fix/observability-voltage-count-check branch November 21, 2024 09:10
@Jerry-Jinfeng-Guo Jerry-Jinfeng-Guo changed the title Fix / Observability internal voltage count check Observability: internal voltage count check May 13, 2025
@Jerry-Jinfeng-Guo Jerry-Jinfeng-Guo added the bug Something isn't working label May 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants