Skip to content

Keep only important integration tests: step 3 #846

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
Nov 27, 2024
Merged

Keep only important integration tests: step 3 #846

merged 11 commits into from
Nov 27, 2024

Conversation

mgovers
Copy link
Member

@mgovers mgovers commented Nov 27, 2024

  • Migrate test_main_model_se.cpp to either API tests or validation tests
  • Move update-specific main model api tests from test_api_model.cpp to test_api_model_update.cpp

Please do not merge before #841 is merged

@mgovers
move single node source SE sym voltage to validation
ba499ff 
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
@mgovers
move single node source SE asym voltage to validation
618bcef 
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
@mgovers
migrate node injection state estimation integration tests
3dfa70e 
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
@mgovers
migrate line power sensor se integration tests
1e82da8 
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
@mgovers
remove duplicate incomplete input complete update
190352d 
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
@mgovers
split up test_api_model.cpp
e7b8654 
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
@mgovers
migrate forbid link measurements test to test api model
a6531c9 
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
@mgovers
finally remove test_main_model_se.cpp
e3a9244 
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
@mgovers
remove redundant fields from forbid link power measurements test
35fe60f 
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
@mgovers mgovers added improvement Improvement on internal implementation do-not-merge This should not be merged labels Nov 27, 2024
@mgovers mgovers self-assigned this Nov 27, 2024
@mgovers mgovers marked this pull request as ready for review November 27, 2024 09:27
Base automatically changed from feature/only-important-integration-tests-2 to main November 27, 2024 09:59
An error occurred while trying to automatically change base from feature/only-important-integration-tests-2 to main November 27, 2024 09:59
@mgovers mgovers removed the do-not-merge This should not be merged label Nov 27, 2024
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@TonyXiang8787 TonyXiang8787 added this pull request to the merge queue Nov 27, 2024
Merged via the queue into main with commit 67b0f30 Nov 27, 2024
27 checks passed
@TonyXiang8787 TonyXiang8787 deleted the feature/only-important-integration-tests-3 branch November 27, 2024 19:34
@mgovers mgovers mentioned this pull request Nov 28, 2024
Merged
5 tasks
@mgovers mgovers changed the title Feature/only important integration tests 3 keep only important integration tests: step 3 Nov 28, 2024
@mgovers mgovers mentioned this pull request Nov 28, 2024
Merged
2 tasks
@Jerry-Jinfeng-Guo Jerry-Jinfeng-Guo changed the title keep only important integration tests: step 3 Keep only important integration tests: step 3 May 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TonyXiang8787 TonyXiang8787 TonyXiang8787 approved these changes

Assignees

@mgovers mgovers

Labels
improvement Improvement on internal implementation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mgovers @TonyXiang8787