Skip to content

Keep only important integration tests: step 4 #847

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 15 commits into from
Nov 29, 2024
Merged

Keep only important integration tests: step 4 #847

merged 15 commits into from
Nov 29, 2024

Conversation

@mgovers
Copy link
Member

@mgovers mgovers commented Nov 28, 2024 •
edited
Loading

  • Splits math solver into separate test files per solver type
    • migrate PF solvers
    • migrate SE solvers
    • migrate SC solver
    • migrate other tests
    • delete test_math_solver.cpp
  • Formats test case templates more nicely

Relates to #486
Continuation of:

@mgovers
migrate short circuit solver out of math solver
4159db5 
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
@mgovers
split test_math_solver.cpp pf tests into test per solver
dd52046 
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
@mgovers
remove redundant power flow tests from test_math_solver.cpp
63a7b5e 
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
@mgovers
better formatting API update id tests
b9473e1 
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
@mgovers
combine type_as_string with template
161dc5f 
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
@mgovers
more type to string for template doctest
8fdf753 
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
@mgovers mgovers added improvement Improvement on internal implementation do-not-merge This should not be merged labels Nov 28, 2024
@mgovers mgovers self-assigned this Nov 28, 2024
@mgovers
migrate math solver se tests
ad014f7 
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
@mgovers
migrate remaining SE tests
f2fde16 
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
@mgovers
migrate test wrong calculation type out of test_math_solver
df0739a 
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
@mgovers
remove redundant test_math_solver.cpp tests
0aa0eb7 
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
@mgovers mgovers removed the do-not-merge This should not be merged label Nov 28, 2024
@mgovers
remove some code duplication
cd9acdc 
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
@mgovers
rewrite even more to speed up compilation speed
091b9de 
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
@mgovers
minor cleanup
9f8d420 
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
@mgovers
sonar cloud
426a238 
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
@mgovers mgovers changed the title Feature/only important integration tests 4 keep only important integration tests: step 4 Nov 28, 2024
@mgovers
clang-tidy
155dfd8 
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
@sonarqubecloud
Copy link

sonarqubecloud bot commented Nov 28, 2024

Quality Gate Passed Quality Gate passed

Issues
10 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@mgovers mgovers marked this pull request as ready for review November 28, 2024 16:29
@mgovers mgovers mentioned this pull request Nov 28, 2024
Merged
2 tasks
@TonyXiang8787 TonyXiang8787 added this pull request to the merge queue Nov 29, 2024
Merged via the queue into main with commit e6b075d Nov 29, 2024
27 checks passed
@TonyXiang8787 TonyXiang8787 deleted the feature/only-important-integration-tests-4 branch November 29, 2024 08:59
@Jerry-Jinfeng-Guo Jerry-Jinfeng-Guo changed the title keep only important integration tests: step 4 Keep only important integration tests: step 4 May 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TonyXiang8787 TonyXiang8787 TonyXiang8787 approved these changes

Assignees

@mgovers mgovers

Labels

improvement Improvement on internal implementation

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mgovers @TonyXiang8787