Skip to content

Keep only important integration tests: step 5 #848

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 41 commits into from
Dec 4, 2024
Merged

Keep only important integration tests: step 5 #848

merged 41 commits into from
Dec 4, 2024

Conversation

mgovers
Copy link
Member

@mgovers mgovers commented Nov 28, 2024 •
edited
Loading

@mgovers
migrate indexer main model test to test api model
39f5ef3 
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
@mgovers
migrate duplicated id + non existing id checks to test api model
5e28a87 
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
@mgovers
migrate test id for wrong type
71f67df 
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
@mgovers
migrate update with unknown id
e940d99 
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
@mgovers mgovers added improvement Improvement on internal implementation do-not-merge This should not be merged labels Nov 28, 2024
@mgovers mgovers self-assigned this Nov 28, 2024
@mgovers
remove some restore logic testing
eab6a6f 
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
@TonyXiang8787 TonyXiang8787 changed the base branch from main to feature/only-important-integration-tests-4 November 29, 2024 08:13
Base automatically changed from feature/only-important-integration-tests-4 to main November 29, 2024 08:59
mgovers added 17 commits December 2, 2024 10:51
@mgovers
attempt with heap corruption
6762c75 
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
@mgovers
fix heap corruption
88114ed 
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
@mgovers
add enum for calculation symmetry
d237fee 
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
@mgovers
minor
15e4a89 
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
@mgovers
move misc api model test to regular api model test
cc254ef 
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
@mgovers
remove duplicate test
74e7e75 
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
@mgovers
migrate updates with alternating compute mode test
b879932 
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
@mgovers
remove redundant code
69590af 
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
@mgovers
remove more redundant tests from test api model misc
c3fd36d 
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
@mgovers
fully migrate incomplete input test
c57e4f6 
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
@mgovers
minor cleanup
18514d7 
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
@mgovers
migrate final test
e88c4b5 
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
@mgovers
finally remove last main model integration tests
84b60ba 
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
@mgovers
remove deprecated functionality; make more main model private
749e64d 
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
@mgovers
merge api model misc into api model update tests
f4c3920 
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
@mgovers
remove todo
7e1cb78 
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
@mgovers
Merge remote-tracking branch 'origin/main' into feature/only-importan…
1578616 
…t-integration-tests-5
@mgovers mgovers removed the do-not-merge This should not be merged label Dec 2, 2024
@mgovers mgovers marked this pull request as ready for review December 2, 2024 15:42
@mgovers
fix clang tidy
c897c03 
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
@mgovers mgovers mentioned this pull request Dec 3, 2024
Merged
figueroa1395
figueroa1395 reviewed Dec 3, 2024
View reviewed changes
Copy link
Contributor

@figueroa1395 figueroa1395 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, just left some minor comments.

In addition, once all clang-tidy/sonar stuff is fixed, I will trigger a manual run of the nightly build to "benchmark" compilation speed more accurately. I will report back when is done.

@mgovers
merge get indexer C API tests
29e8b68 
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
@mgovers
use C++17 features in C++ wrapper
bacf4f0 
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
@mgovers
calng-tidy
6309aa5 
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
@mgovers
tests per attribute
7e56733 
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
@mgovers
debug macos release
c69b8d8 
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
@mgovers
debug macos
566ff3f 
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
@mgovers
Merge remote-tracking branch 'origin/main' into feature/only-importan…
efcca25 
…t-integration-tests-5

Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
@mgovers
sonar-cloud + clang-tidy
8f5862f 
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
@mgovers
resolve comments + fix ci
81936f6 
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
@figueroa1395
Copy link
Contributor

Manual nightly build run for benchmark purposes: https://github.com/PowerGridModel/power-grid-model/actions/runs/12142643442. After it has run, I will document here the improvement and also check the box in the PR description.

mgovers and others added 4 commits December 4, 2024 08:59
@mgovers
Merge branch 'main' into feature/only-important-integration-tests-5
ca918e2
@mgovers
fix full clang-tidy build
e6a4ea8 
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
@mgovers
use bool is_batch instead of Idx in cpp wrapper
08a0b6b 
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
@mgovers
more full clang-tidy
5cb7a28 
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Dec 4, 2024

Quality Gate Passed Quality Gate passed

Issues
24 New issues
0 Accepted issues

Measures
0 Security Hotspots
95.8% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@TonyXiang8787 TonyXiang8787 added this pull request to the merge queue Dec 4, 2024
Merged via the queue into main with commit 4954709 Dec 4, 2024
30 of 32 checks passed
@TonyXiang8787 TonyXiang8787 deleted the feature/only-important-integration-tests-5 branch December 4, 2024 10:02
This was referenced Dec 4, 2024
Merged
Merged
@mgovers mgovers mentioned this pull request Dec 12, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@figueroa1395 figueroa1395 figueroa1395 left review comments

@TonyXiang8787 TonyXiang8787 TonyXiang8787 approved these changes

Assignees

@mgovers mgovers

Labels
improvement Improvement on internal implementation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mgovers @figueroa1395 @TonyXiang8787