-
Notifications
You must be signed in to change notification settings - Fork 35
Add LU solver documentation #890
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
mgovers
commented
Feb 7, 2025
•
edited
Loading
edited
- Add LU solver documentation
- Rationale
- Implementation
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
78c6fe8
to
794e15e
Compare
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
@TonyXiang8787 this is ready for a first review round. I will spend some time tomorrow on going through all the documentation from start to finish myself as well to check if the structure still makes sense, but some feedback would be nice as well at this stage. |
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
53051da
to
f2551a8
Compare
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Up until Block-sparse LU-factorization
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Up to Pivot perturbation
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
@mgovers I have resolved all my previous comments. But I think I made a mistake to propose using |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is my final sprint in this review. I will try and go over the comments from my previous reviews but I believe if there is a matter opinion difference, you can proceed by resolving mine. If I made a factual mistake in certain comment, you can also resolve them directly.
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
While a very small change, I believe it makes the difference between matrices and vectors almost disappear, and even more so for vectors of matrices. E.g.: what do you propose? |
Even though you have a point, I find the new "font" more aesthetic and easier on the eyes. That is probably subjective, but I would keep the new version. |
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
cfr. this and offline discussion with tony: |
Since all other comments are resolved, I will now do the |
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
IT'S HAPPENING |
|