Measurement statistics module#896
Merged
Jerry-Jinfeng-Guo merged 46 commits intomainfrom Feb 28, 2025
Merged
Conversation
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
…impl Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
Signed-off-by: Nitish Bharambe <nitish.bharambe@alliander.com>
Signed-off-by: Nitish Bharambe <nitish.bharambe@alliander.com>
Signed-off-by: Nitish Bharambe <nitish.bharambe@alliander.com>
Signed-off-by: Nitish Bharambe <nitish.bharambe@alliander.com>
Signed-off-by: Nitish Bharambe <nitish.bharambe@alliander.com>
Signed-off-by: Nitish Bharambe <nitish.bharambe@alliander.com>
Signed-off-by: Nitish Bharambe <nitish.bharambe@alliander.com>
mgovers
reviewed
Feb 17, 2025
Signed-off-by: Nitish Bharambe <nitish.bharambe@alliander.com>
Signed-off-by: Nitish Bharambe <nitish.bharambe@alliander.com>
Signed-off-by: Nitish Bharambe <nitish.bharambe@alliander.com>
mgovers
reviewed
Feb 18, 2025
Member
mgovers
left a comment
mgovers
left a comment
There was a problem hiding this comment.
from a very quick look it seems OK to me, but maybe it's good to let someone else review, as i've written a significant part of the code
Signed-off-by: Nitish Bharambe <nitish.bharambe@alliander.com>
Member
Author
True, asked @Jerry-Jinfeng-Guo . |
Signed-off-by: Nitish Bharambe <nitish.bharambe@alliander.com>
Signed-off-by: Nitish Bharambe <nitish.bharambe@alliander.com>
…omponent/current_sensor.hpp Signed-off-by: Nitish Bharambe <78108900+nitbharambe@users.noreply.github.com>
Signed-off-by: Nitish Bharambe <nitish.bharambe@alliander.com>
Signed-off-by: Nitish Bharambe <nitish.bharambe@alliander.com>
Signed-off-by: Nitish Bharambe <nitish.bharambe@alliander.com>
Signed-off-by: Nitish Bharambe <nitish.bharambe@alliander.com>
Signed-off-by: Nitish Bharambe <nitish.bharambe@alliander.com>
Signed-off-by: Nitish Bharambe <nitish.bharambe@alliander.com>
Member
figueroa1395
left a comment
figueroa1395
left a comment
There was a problem hiding this comment.
Pretty cool module. Nice job. Also, very thorough testing!
Member
|
it's a good sign that there are as many questions about the actual contents of this change as there are. It proves that making a separate statistics module was really really needed |
Signed-off-by: Nitish Bharambe <nitish.bharambe@alliander.com>
figueroa1395
previously approved these changes
Feb 28, 2025
Jerry-Jinfeng-Guo
previously approved these changes
Feb 28, 2025
Jerry-Jinfeng-Guo
removed this pull request from the merge queue due to a manual request
Current sensor component functionality
Jerry-Jinfeng-Guo
dismissed stale reviews from figueroa1395 and themself
via
101936d
Jerry-Jinfeng-Guo
approved these changes
Feb 28, 2025
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements variance related calculations mentioned in # #547
Changes proposed in this PR include:
A generic module for handling different types of variances in state estimation.
Could you please pay extra attention to the points below when reviewing the PR: