Skip to content

Measurement statistics module #896

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 46 commits into from
Feb 28, 2025
Merged

Measurement statistics module #896

merged 46 commits into from
Feb 28, 2025

Conversation

nitbharambe
Copy link
Member

Implements variance related calculations mentioned in # #547

Changes proposed in this PR include:

A generic module for handling different types of variances in state estimation.

Could you please pay extra attention to the points below when reviewing the PR:

mgovers and others added 14 commits February 4, 2025 15:56
@mgovers
add statistics module setup
5c8d7b3 
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
@mgovers
minor refactor
e606f4c 
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
@mgovers
add calculation parameter tests
698bc1f 
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
@mgovers
add sym calculation params for symmetric current sensor
dab85bc 
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
@mgovers
unit tests for statistics
4f63f86 
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
@mgovers
extend statistics functionality
d5234f1 
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
@mgovers
Merge branch 'feature/statistics-module' into feature/current-sensor-…
159dd45 
…impl

Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
@nitbharambe
change to rdv and add some tests
deffcfd 
Signed-off-by: Nitish Bharambe <nitish.bharambe@alliander.com>
@nitbharambe
add decomposed rough
a2fe613 
Signed-off-by: Nitish Bharambe <nitish.bharambe@alliander.com>
@nitbharambe
rename rdv 2
befc6c8 
Signed-off-by: Nitish Bharambe <nitish.bharambe@alliander.com>
@nitbharambe
fix polar tests non conversion
3e20a34 
Signed-off-by: Nitish Bharambe <nitish.bharambe@alliander.com>
@nitbharambe
add remaining tests
72013ec 
Signed-off-by: Nitish Bharambe <nitish.bharambe@alliander.com>
@nitbharambe
wip tests correction
2581a62 
Signed-off-by: Nitish Bharambe <nitish.bharambe@alliander.com>
@nitbharambe
fix remaining
f7cd9eb 
Signed-off-by: Nitish Bharambe <nitish.bharambe@alliander.com>
@nitbharambe
cleanup
279e3a9 
Signed-off-by: Nitish Bharambe <nitish.bharambe@alliander.com>
@nitbharambe
structured bindings ref
0012881 
Signed-off-by: Nitish Bharambe <nitish.bharambe@alliander.com>
@nitbharambe
remove irrelavant todos
30f1787 
Signed-off-by: Nitish Bharambe <nitish.bharambe@alliander.com>
@nitbharambe nitbharambe marked this pull request as ready for review February 17, 2025 14:28
mgovers
mgovers reviewed Feb 18, 2025
View reviewed changes
Copy link
Member

@mgovers mgovers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

from a very quick look it seems OK to me, but maybe it's good to let someone else review, as i've written a significant part of the code

@nitbharambe
add decomposed sym asym conversions
79db492 
Signed-off-by: Nitish Bharambe <nitish.bharambe@alliander.com>
@nitbharambe
Copy link
Member Author

from a very quick look it seems OK to me, but maybe it's good to let someone else review, as i've written a significant part of the code

True, asked @Jerry-Jinfeng-Guo .

@Jerry-Jinfeng-Guo Jerry-Jinfeng-Guo added the feature New feature or request label Feb 25, 2025
nitbharambe and others added 7 commits February 25, 2025 11:17
@nitbharambe
Update power_grid_model_c/power_grid_model/include/power_grid_model/c…
4d37735 
…omponent/current_sensor.hpp

Signed-off-by: Nitish Bharambe <78108900+nitbharambe@users.noreply.github.com>
@nitbharambe
add tests and fixes
5f9ab40 
Signed-off-by: Nitish Bharambe <nitish.bharambe@alliander.com>
@nitbharambe
shorten tests
12eb949 
Signed-off-by: Nitish Bharambe <nitish.bharambe@alliander.com>
@nitbharambe
change shift to loop
5ee89e4 
Signed-off-by: Nitish Bharambe <nitish.bharambe@alliander.com>
@nitbharambe
Merge branch 'feature/statistics-module' into feature/current-sensor-…
981a65a 
…impl
@nitbharambe
add equation docs
fb6da0f 
Signed-off-by: Nitish Bharambe <nitish.bharambe@alliander.com>
@nitbharambe
resolve docstring comments
2eba909 
Signed-off-by: Nitish Bharambe <nitish.bharambe@alliander.com>
@nitbharambe nitbharambe marked this pull request as ready for review February 27, 2025 08:44
@nitbharambe
change order of initialization
273bbcd 
Signed-off-by: Nitish Bharambe <nitish.bharambe@alliander.com>
figueroa1395
figueroa1395 reviewed Feb 27, 2025
View reviewed changes
Copy link
Contributor

@figueroa1395 figueroa1395 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pretty cool module. Nice job. Also, very thorough testing!

@mgovers
Copy link
Member

mgovers commented Feb 27, 2025

it's a good sign that there are as many questions about the actual contents of this change as there are. It proves that making a separate statistics module was really really needed

@nitbharambe
remove todos
83838ec 
Signed-off-by: Nitish Bharambe <nitish.bharambe@alliander.com>
figueroa1395
figueroa1395 previously approved these changes Feb 28, 2025
View reviewed changes
@Jerry-Jinfeng-Guo Jerry-Jinfeng-Guo added this pull request to the merge queue Feb 28, 2025
@Jerry-Jinfeng-Guo Jerry-Jinfeng-Guo removed this pull request from the merge queue due to a manual request Feb 28, 2025
@Jerry-Jinfeng-Guo Jerry-Jinfeng-Guo dismissed stale reviews from figueroa1395 and themself via 101936d February 28, 2025 12:44
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
4 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@Jerry-Jinfeng-Guo Jerry-Jinfeng-Guo added this pull request to the merge queue Feb 28, 2025
Merged via the queue into main with commit 4d153e9 Feb 28, 2025
28 checks passed
@Jerry-Jinfeng-Guo Jerry-Jinfeng-Guo deleted the feature/statistics-module branch February 28, 2025 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mgovers mgovers mgovers left review comments

@Jerry-Jinfeng-Guo Jerry-Jinfeng-Guo Jerry-Jinfeng-Guo approved these changes

@figueroa1395 figueroa1395 figueroa1395 left review comments

Assignees

@nitbharambe nitbharambe

Labels
feature New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@nitbharambe @mgovers @Jerry-Jinfeng-Guo @figueroa1395