Skip to content

Added generic branch example #898

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

scud-soptim
Copy link
Contributor

Added Example and Documentation for Issue: #729

Changes proposed in this PR include:

  • Added usage examples for the Generic Branch.
  • Included documentation on how to use the Generic Branch with CIM/CGMES datasets.

Signed-off-by: Udo Schmitz <udo.schmitz@soptim.de>
Signed-off-by: Udo Schmitz <udo.schmitz@soptim.de>
@TonyXiang8787 TonyXiang8787 added this pull request to the merge queue Feb 14, 2025
Merged via the queue into PowerGridModel:main with commit 6d8caab Feb 14, 2025
26 checks passed
@TonyXiang8787
Copy link
Member

Hi @scud-soptim,

Thanks for the example. We forgot to add the new notebook to the table of content in the documentation. Can you create a new PR to do it? See below

```{toctree}
:caption: "Examples"
:maxdepth: 2
examples/Power Flow Example.ipynb
examples/Serialization Example.ipynb
examples/State Estimation Example.ipynb
examples/Short Circuit Example.ipynb
examples/Validation Examples.ipynb
examples/Make Test Dataset.ipynb
examples/Asymmetric Calculation Example.ipynb
examples/Transformer Examples.ipynb
```

@mgovers
Copy link
Member

mgovers commented Feb 17, 2025

Hi @scud-soptim,

Thanks for the example. We forgot to add the new notebook to the table of content in the documentation. Can you create a new PR to do it? See below

```{toctree}
:caption: "Examples"
:maxdepth: 2
examples/Power Flow Example.ipynb
examples/Serialization Example.ipynb
examples/State Estimation Example.ipynb
examples/Short Circuit Example.ipynb
examples/Validation Examples.ipynb
examples/Make Test Dataset.ipynb
examples/Asymmetric Calculation Example.ipynb
examples/Transformer Examples.ipynb
```

Thank you @scud-soptim for the example!

In addition to what @TonyXiang8787 mentioned: I also noticed that there are German comments in the example. Can you please translate them to English in the same follow-up PR?

@Jerry-Jinfeng-Guo Jerry-Jinfeng-Guo added the improvement Improvement on internal implementation label May 13, 2025
@Jerry-Jinfeng-Guo Jerry-Jinfeng-Guo changed the title added generic branch example Added generic branch example May 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Improvement on internal implementation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants