Skip to content

Generic branch: small fixes to the documentation #901

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Feb 18, 2025

Conversation

scud-soptim
Copy link
Contributor

Fix for Documentation Issue: #900

Changes proposed in this PR:

  • Removed German comments
  • Reformatted Python code examples
  • Fixed Markdown formatting

Signed-off-by: Udo Schmitz <udo.schmitz@soptim.de>
Copy link
Member

@mgovers mgovers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @scud-soptim , Nice findings. Before we accidentally merge too quickly again, can you please go over everything again and let us know when it's ready (or pull the PR back to draft if there is still work required). That way we can reduce the amount of follow-up PRs

Signed-off-by: Udo Schmitz <udo.schmitz@soptim.de>
@scud-soptim
Copy link
Contributor Author

internal review done, this should be the final version

Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
@mgovers mgovers enabled auto-merge February 18, 2025 14:53
@mgovers mgovers added this pull request to the merge queue Feb 18, 2025
Merged via the queue into PowerGridModel:main with commit 29d40b2 Feb 18, 2025
26 checks passed
@scud-soptim scud-soptim deleted the fix-doc-gen-branch branch February 18, 2025 17:01
@Jerry-Jinfeng-Guo Jerry-Jinfeng-Guo changed the title small fixes Generic branch: small fixes to the documentation May 13, 2025
@Jerry-Jinfeng-Guo Jerry-Jinfeng-Guo added the documentation Improvements or additions to documentation label May 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants