-
Notifications
You must be signed in to change notification settings - Fork 35
Current sensor component functionality #903
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Jerry-Jinfeng-Guo
merged 19 commits into
feature/statistics-module
from
feature/current-sensor-impl
Feb 28, 2025
Merged
Current sensor component functionality #903
Jerry-Jinfeng-Guo
merged 19 commits into
feature/statistics-module
from
feature/current-sensor-impl
Feb 28, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
…impl Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
Signed-off-by: Nitish Bharambe <nitish.bharambe@alliander.com>
Signed-off-by: Nitish Bharambe <nitish.bharambe@alliander.com>
Signed-off-by: Nitish Bharambe <nitish.bharambe@alliander.com>
Signed-off-by: Nitish Bharambe <nitish.bharambe@alliander.com>
nitbharambe
commented
Feb 25, 2025
power_grid_model_c/power_grid_model/include/power_grid_model/component/current_sensor.hpp
Outdated
Show resolved
Hide resolved
…omponent/current_sensor.hpp Signed-off-by: Nitish Bharambe <78108900+nitbharambe@users.noreply.github.com>
Signed-off-by: Nitish Bharambe <nitish.bharambe@alliander.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
power_grid_model_c/power_grid_model/include/power_grid_model/component/current_sensor.hpp
Outdated
Show resolved
Hide resolved
Signed-off-by: Nitish Bharambe <nitish.bharambe@alliander.com>
figueroa1395
approved these changes
Feb 28, 2025
Jerry-Jinfeng-Guo
approved these changes
Feb 28, 2025
101936d
into
feature/statistics-module
24 of 25 checks passed
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to #547
Changes proposed in this PR include: