Skip to content

Use cmake to build the DLL for conda package #915

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 21 commits into from
Mar 11, 2025

Conversation

TonyXiang8787
Copy link
Member

Use cmake to build the DLL/SO for conda package. In runtime, if the power_grid_core detects that it is in conda environment, load the DLL/SO from PATH.

Signed-off-by: Tony Xiang <19280867+TonyXiang8787@users.noreply.github.com>
Signed-off-by: Tony Xiang <19280867+TonyXiang8787@users.noreply.github.com>
Signed-off-by: Tony Xiang <19280867+TonyXiang8787@users.noreply.github.com>
Signed-off-by: Tony Xiang <19280867+TonyXiang8787@users.noreply.github.com>
Signed-off-by: Tony Xiang <19280867+TonyXiang8787@users.noreply.github.com>
Signed-off-by: Tony Xiang <19280867+TonyXiang8787@users.noreply.github.com>
Signed-off-by: Tony Xiang <19280867+TonyXiang8787@users.noreply.github.com>
Signed-off-by: Tony Xiang <19280867+TonyXiang8787@users.noreply.github.com>
Signed-off-by: Tony Xiang <19280867+TonyXiang8787@users.noreply.github.com>
Signed-off-by: Tony Xiang <19280867+TonyXiang8787@users.noreply.github.com>
Signed-off-by: Tony Xiang <19280867+TonyXiang8787@users.noreply.github.com>
Signed-off-by: Tony Xiang <19280867+TonyXiang8787@users.noreply.github.com>
Signed-off-by: Tony Xiang <19280867+TonyXiang8787@users.noreply.github.com>
Signed-off-by: Tony Xiang <19280867+TonyXiang8787@users.noreply.github.com>
Signed-off-by: Tony Xiang <19280867+TonyXiang8787@users.noreply.github.com>
Signed-off-by: Tony Xiang <19280867+TonyXiang8787@users.noreply.github.com>
Signed-off-by: Tony Xiang <19280867+TonyXiang8787@users.noreply.github.com>
Signed-off-by: Tony Xiang <19280867+TonyXiang8787@users.noreply.github.com>
Signed-off-by: Tony Xiang <19280867+TonyXiang8787@users.noreply.github.com>
@TonyXiang8787 TonyXiang8787 requested a review from mgovers March 11, 2025 08:02
@TonyXiang8787 TonyXiang8787 marked this pull request as ready for review March 11, 2025 08:03
Signed-off-by: Tony Xiang <19280867+TonyXiang8787@users.noreply.github.com>
Signed-off-by: Tony Xiang <19280867+TonyXiang8787@users.noreply.github.com>
Copy link
Member

@mgovers mgovers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a question more out of personal interest: what's the reason the dylib is only used for MacOS for conda and not for PGM? is that something we need to fix?

@TonyXiang8787 TonyXiang8787 enabled auto-merge March 11, 2025 10:47
@TonyXiang8787 TonyXiang8787 added this pull request to the merge queue Mar 11, 2025
Merged via the queue into main with commit 3f086d7 Mar 11, 2025
28 checks passed
@TonyXiang8787 TonyXiang8787 deleted the feature/conda-build-cmake branch March 11, 2025 11:04
@TonyXiang8787
Copy link
Member Author

a question more out of personal interest: what's the reason the dylib is only used for MacOS for conda and not for PGM? is that something we need to fix?

@mgovers cmake in macOS produces .dylib for shared library. setuptools in macOS produces .so in compiled extension. We are just following the convention.

@mgovers
Copy link
Member

mgovers commented Mar 11, 2025

a question more out of personal interest: what's the reason the dylib is only used for MacOS for conda and not for PGM? is that something we need to fix?

@mgovers cmake in macOS produces .dylib for shared library. setuptools in macOS produces .so in compiled extension. We are just following the convention.

clear, thanks!

@Jerry-Jinfeng-Guo Jerry-Jinfeng-Guo added the dependencies Pull requests that update a dependency file label May 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants