Skip to content

Clang tidy 19 support (bis) #928

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 24 commits into from
Mar 21, 2025
Merged

Clang tidy 19 support (bis) #928

merged 24 commits into from
Mar 21, 2025

Conversation

mgovers
Copy link
Member

@mgovers mgovers commented Mar 19, 2025

Attempt 2 at #922 . It was accidentally merged, most likely due to a bug in GitHub: I changed the base branch, but instead of rebasing, it actually merged the PR into the new base branch.

Make sure that the code compiles with the latest clang-tidy (Windows; shipped with latest Visual Studio)

We disable the following cfr. the offline discussion:

mgovers and others added 20 commits March 17, 2025 12:12
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>

revert readability-math-missing-parentheses and boost-use-ranges

Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>

revert readability-redundant-member-init

Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
This reverts commit 8331341.

Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
…e/use-std-views

Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
Signed-off-by: Martijn Govers <martijn.govers@alliander.com>
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
…ure/use-std-views

Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
…e/use-std-views

Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
…ng-tidy-19

Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
…ure/clang-tidy-19

Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
@mgovers mgovers added the improvement Improvement on internal implementation label Mar 19, 2025
@mgovers mgovers self-assigned this Mar 19, 2025
@mgovers mgovers changed the title Feature/clang tidy 19 Clang tidy 19 support (bis) Mar 19, 2025
mgovers and others added 2 commits March 19, 2025 15:27
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
@mgovers mgovers enabled auto-merge March 20, 2025 11:31
Copy link
Contributor

@figueroa1395 figueroa1395 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Just a couple of minor comments.

Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
@mgovers mgovers added this pull request to the merge queue Mar 21, 2025
Merged via the queue into main with commit 840e833 Mar 21, 2025
28 checks passed
@mgovers mgovers deleted the feature/clang-tidy-19 branch March 21, 2025 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Improvement on internal implementation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants